Title: [179202] trunk/Source/_javascript_Core
- Revision
- 179202
- Author
- [email protected]
- Date
- 2015-01-27 12:25:04 -0800 (Tue, 27 Jan 2015)
Log Message
REGRESSION(r178591): 20% regression in Octane box2d
https://bugs.webkit.org/show_bug.cgi?id=140948
Reviewed by Geoffrey Garen.
Added check that we have a lexical environment to the arguments is captured check.
It doesn't make sense to resolve "arguments" when it really isn't captured.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::willResolveToArgumentsRegister):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (179201 => 179202)
--- trunk/Source/_javascript_Core/ChangeLog 2015-01-27 20:16:31 UTC (rev 179201)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-01-27 20:25:04 UTC (rev 179202)
@@ -1,3 +1,16 @@
+2015-01-27 Michael Saboff <[email protected]>
+
+ REGRESSION(r178591): 20% regression in Octane box2d
+ https://bugs.webkit.org/show_bug.cgi?id=140948
+
+ Reviewed by Geoffrey Garen.
+
+ Added check that we have a lexical environment to the arguments is captured check.
+ It doesn't make sense to resolve "arguments" when it really isn't captured.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::willResolveToArgumentsRegister):
+
2015-01-26 Geoffrey Garen <[email protected]>
Use FastMalloc (bmalloc) instead of BlockAllocator for GC pages
Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (179201 => 179202)
--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2015-01-27 20:16:31 UTC (rev 179201)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2015-01-27 20:25:04 UTC (rev 179202)
@@ -575,7 +575,7 @@
if (entry.isNull())
return false;
- if (m_localArgumentsRegister && isCaptured(m_localArgumentsRegister->index()))
+ if (m_localArgumentsRegister && isCaptured(m_localArgumentsRegister->index()) && m_lexicalEnvironmentRegister)
return false;
if (m_codeBlock->usesArguments() && m_codeType == FunctionCode && m_localArgumentsRegister)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
