Title: [179225] trunk/Tools
Revision
179225
Author
[email protected]
Date
2015-01-27 15:38:02 -0800 (Tue, 27 Jan 2015)

Log Message

[Win] WinLauncher crashes on eleventh site visited
https://bugs.webkit.org/show_bug.cgi?id=140960

Reviewed by Anders Carlsson.

* WinLauncher/WinLauncher.cpp:
(WinLauncher::showLastVisitedSites): Don't access off the end of
the history array.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (179224 => 179225)


--- trunk/Tools/ChangeLog	2015-01-27 23:34:51 UTC (rev 179224)
+++ trunk/Tools/ChangeLog	2015-01-27 23:38:02 UTC (rev 179225)
@@ -1,3 +1,14 @@
+2015-01-27  Brent Fulgham  <[email protected]>
+
+        [Win] WinLauncher crashes on eleventh site visited
+        https://bugs.webkit.org/show_bug.cgi?id=140960
+
+        Reviewed by Anders Carlsson.
+
+        * WinLauncher/WinLauncher.cpp:
+        (WinLauncher::showLastVisitedSites): Don't access off the end of
+        the history array.
+
 2015-01-27  Alexey Proskuryakov  <[email protected]>
 
         [Mac] Disable building Java applets by default

Modified: trunk/Tools/WinLauncher/WinLauncher.cpp (179224 => 179225)


--- trunk/Tools/WinLauncher/WinLauncher.cpp	2015-01-27 23:34:51 UTC (rev 179224)
+++ trunk/Tools/WinLauncher/WinLauncher.cpp	2015-01-27 23:38:02 UTC (rev 179225)
@@ -276,7 +276,7 @@
         allItemsOffset = totalListCount - maxHistorySize;
 
     int currentHistoryItem = 0;
-    for (int i = 0; i < totalListCount; ++i) {
+    for (int i = 0; i < m_historyItems.size() && (allItemsOffset + currentHistoryItem) < m_historyItems.size(); ++i) {
         updateMenuItemForHistoryItem(menu, *(m_historyItems[allItemsOffset + currentHistoryItem]), currentHistoryItem);
         ++currentHistoryItem;
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to