Modified: trunk/Tools/ChangeLog (179247 => 179248)
--- trunk/Tools/ChangeLog 2015-01-28 09:33:54 UTC (rev 179247)
+++ trunk/Tools/ChangeLog 2015-01-28 13:44:56 UTC (rev 179248)
@@ -1,3 +1,17 @@
+2015-01-28 Carlos Garcia Campos <[email protected]>
+
+ [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
+ https://bugs.webkit.org/show_bug.cgi?id=131731
+
+ Reviewed by Žan Doberšek.
+
+ A web page loaded offscreen is in prerender state not hidden.
+
+ * Scripts/run-gtk-tests:
+ (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
+ * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
+ (testWebViewPageVisibility):
+
2015-01-27 Alexey Proskuryakov <[email protected]>
Partially revert r178802.
Modified: trunk/Tools/Scripts/run-gtk-tests (179247 => 179248)
--- trunk/Tools/Scripts/run-gtk-tests 2015-01-28 09:33:54 UTC (rev 179247)
+++ trunk/Tools/Scripts/run-gtk-tests 2015-01-28 13:44:56 UTC (rev 179248)
@@ -64,7 +64,6 @@
SkippedTest("WebKit2Gtk/TestUIClient", "/webkit2/WebKitWebView/mouse-target", "Test times out after r150890", 117689),
SkippedTest("WebKit2Gtk/TestContextMenu", SkippedTest.ENTIRE_SUITE, "Test times out after r150890", 117689),
SkippedTest("WebKit2APITests/TestWebKitAccessibility", "/webkit2/WebKitAccessibility/atspi-basic-hierarchy", "Test is flaky", 132134),
- SkippedTest("WebKit2Gtk/TestWebKitWebView", "/webkit2/WebKitWebView/page-visibility", "Test fails or times out", 131731),
SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580),
SkippedTest("WebKit2/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
SkippedTest("WebKit2/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp (179247 => 179248)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp 2015-01-28 09:33:54 UTC (rev 179247)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp 2015-01-28 13:44:56 UTC (rev 179248)
@@ -455,7 +455,7 @@
g_assert_cmpint(g_file_info_get_size(fileInfo.get()), ==, totalBytesFromStream);
}
-// To test page visibility API. Currently only 'visible' and 'hidden' states are implemented fully in WebCore.
+// To test page visibility API. Currently only 'visible', 'hidden' and 'prerender' states are implemented fully in WebCore.
// See also http://www.w3.org/TR/2011/WD-page-visibility-20110602/ and https://developers.google.com/chrome/whitepapers/pagevisibility
static void testWebViewPageVisibility(WebViewTest* test, gconstpointer)
{
@@ -470,7 +470,7 @@
"</body></html>",
0);
- // Wait untill the page is loaded. Initial visibility should be 'hidden'.
+ // Wait until the page is loaded. Initial visibility should be 'prerender'.
test->waitUntilLoadFinished();
GUniqueOutPtr<GError> error;
@@ -478,7 +478,7 @@
g_assert(_javascript_Result);
g_assert(!error.get());
GUniquePtr<char> valueString(WebViewTest::_javascript_ResultToCString(_javascript_Result));
- g_assert_cmpstr(valueString.get(), ==, "hidden");
+ g_assert_cmpstr(valueString.get(), ==, "prerender");
_javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.hidden;", &error.outPtr());
g_assert(_javascript_Result);
