Title: [179250] trunk/Tools
Revision
179250
Author
[email protected]
Date
2015-01-28 06:48:29 -0800 (Wed, 28 Jan 2015)

Log Message

[GTK] Stop removing color marks from unit tests output
https://bugs.webkit.org/show_bug.cgi?id=140996

Reviewed by Philippe Normand.

Since r178236 google tests use a custom simplified output without
any colors, so we don't need to handle the case of non ttys to
remove the color marks.

* Scripts/run-gtk-tests:
(TestRunner.__init__):
(TestRunner._run_test_command.parse_line):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (179249 => 179250)


--- trunk/Tools/ChangeLog	2015-01-28 14:47:07 UTC (rev 179249)
+++ trunk/Tools/ChangeLog	2015-01-28 14:48:29 UTC (rev 179250)
@@ -1,5 +1,20 @@
 2015-01-28  Carlos Garcia Campos  <[email protected]>
 
+        [GTK] Stop removing color marks from unit tests output
+        https://bugs.webkit.org/show_bug.cgi?id=140996
+
+        Reviewed by Philippe Normand.
+
+        Since r178236 google tests use a custom simplified output without
+        any colors, so we don't need to handle the case of non ttys to
+        remove the color marks.
+
+        * Scripts/run-gtk-tests:
+        (TestRunner.__init__):
+        (TestRunner._run_test_command.parse_line):
+
+2015-01-28  Carlos Garcia Campos  <[email protected]>
+
         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
         https://bugs.webkit.org/show_bug.cgi?id=131731
 

Modified: trunk/Tools/Scripts/run-gtk-tests (179249 => 179250)


--- trunk/Tools/Scripts/run-gtk-tests	2015-01-28 14:47:07 UTC (rev 179249)
+++ trunk/Tools/Scripts/run-gtk-tests	2015-01-28 14:48:29 UTC (rev 179250)
@@ -91,8 +91,6 @@
         self._tests = self._get_tests(tests)
         self._skipped_tests = TestRunner.SKIPPED
         self._disabled_tests = []
-        if not sys.stdout.isatty():
-            self._tty_colors_pattern = re.compile("\033\[[0-9;]*m")
 
         # These SPI daemons need to be active for the accessibility tests to work.
         self._spi_registryd = None
@@ -258,10 +256,7 @@
             if child_pid[0] == -1:
                 child_pid[0] = self._get_child_pid_from_test_output(line)
 
-            if sys.stdout.isatty():
-                sys.stdout.write(line)
-            else:
-                sys.stdout.write(self._tty_colors_pattern.sub('', line.replace('\r', '')))
+            sys.stdout.write(line)
 
         def waitpid(pid):
             while True:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to