Title: [179279] trunk/Source/WebCore
- Revision
- 179279
- Author
- [email protected]
- Date
- 2015-01-28 12:48:19 -0800 (Wed, 28 Jan 2015)
Log Message
Prevent implicit animation when setting fullscreen background to clear.
https://bugs.webkit.org/show_bug.cgi?id=140888
Patch by Jeremy Jones <[email protected]> on 2015-01-28
Reviewed by Eric Carlson.
This patch decreases flicker when exiting fullscreen by preventing
an implicit animation when changing the background to clear.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::exitFullscreenInternal):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (179278 => 179279)
--- trunk/Source/WebCore/ChangeLog 2015-01-28 20:41:01 UTC (rev 179278)
+++ trunk/Source/WebCore/ChangeLog 2015-01-28 20:48:19 UTC (rev 179279)
@@ -1,3 +1,16 @@
+2015-01-28 Jeremy Jones <[email protected]>
+
+ Prevent implicit animation when setting fullscreen background to clear.
+ https://bugs.webkit.org/show_bug.cgi?id=140888
+
+ Reviewed by Eric Carlson.
+
+ This patch decreases flicker when exiting fullscreen by preventing
+ an implicit animation when changing the background to clear.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (WebVideoFullscreenInterfaceAVKit::exitFullscreenInternal):
+
2015-01-28 Dana Burkart <[email protected]>
Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (179278 => 179279)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-01-28 20:41:01 UTC (rev 179278)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-01-28 20:48:19 UTC (rev 179279)
@@ -975,8 +975,13 @@
RefPtr<WebVideoFullscreenInterfaceAVKit> strongThis(this);
[m_playerViewController exitFullScreenWithCompletionHandler:[strongThis] (BOOL, NSError*) {
strongThis->m_exitCompleted = true;
+
+ [CATransaction begin];
+ [CATransaction setDisableActions:YES];
[strongThis->m_videoLayerContainer setBackgroundColor:[[getUIColorClass() clearColor] CGColor]];
[[strongThis->m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
+ [CATransaction commit];
+
WebThreadRun([strongThis] {
if (strongThis->m_fullscreenChangeObserver)
strongThis->m_fullscreenChangeObserver->didExitFullscreen();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
