Title: [179359] trunk/Source/_javascript_Core
- Revision
- 179359
- Author
- [email protected]
- Date
- 2015-01-29 12:56:16 -0800 (Thu, 29 Jan 2015)
Log Message
Use Vector instead of GCSegmentedArray in CodeBlockSet
https://bugs.webkit.org/show_bug.cgi?id=141044
Reviewed by Ryosuke Niwa.
This is allowed now that we've gotten rid of fastMallocForbid.
4kB was a bit overkill for just storing a few pointers.
* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::CodeBlockSet):
* heap/CodeBlockSet.h:
* heap/Heap.cpp:
(JSC::Heap::Heap):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (179358 => 179359)
--- trunk/Source/_javascript_Core/ChangeLog 2015-01-29 20:49:13 UTC (rev 179358)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-01-29 20:56:16 UTC (rev 179359)
@@ -1,3 +1,20 @@
+2015-01-29 Geoffrey Garen <[email protected]>
+
+ Use Vector instead of GCSegmentedArray in CodeBlockSet
+ https://bugs.webkit.org/show_bug.cgi?id=141044
+
+ Reviewed by Ryosuke Niwa.
+
+ This is allowed now that we've gotten rid of fastMallocForbid.
+
+ 4kB was a bit overkill for just storing a few pointers.
+
+ * heap/CodeBlockSet.cpp:
+ (JSC::CodeBlockSet::CodeBlockSet):
+ * heap/CodeBlockSet.h:
+ * heap/Heap.cpp:
+ (JSC::Heap::Heap):
+
2015-01-29 Filip Pizlo <[email protected]>
Unreviewed, fix no-JIT build.
Modified: trunk/Source/_javascript_Core/heap/CodeBlockSet.cpp (179358 => 179359)
--- trunk/Source/_javascript_Core/heap/CodeBlockSet.cpp 2015-01-29 20:49:13 UTC (rev 179358)
+++ trunk/Source/_javascript_Core/heap/CodeBlockSet.cpp 2015-01-29 20:56:16 UTC (rev 179359)
@@ -36,7 +36,6 @@
static const bool verbose = false;
CodeBlockSet::CodeBlockSet()
- : m_currentlyExecuting()
{
}
Modified: trunk/Source/_javascript_Core/heap/CodeBlockSet.h (179358 => 179359)
--- trunk/Source/_javascript_Core/heap/CodeBlockSet.h 2015-01-29 20:49:13 UTC (rev 179358)
+++ trunk/Source/_javascript_Core/heap/CodeBlockSet.h 2015-01-29 20:56:16 UTC (rev 179359)
@@ -109,7 +109,7 @@
// and all, but that seemed like overkill.
HashSet<CodeBlock*> m_oldCodeBlocks;
HashSet<CodeBlock*> m_newCodeBlocks;
- GCSegmentedArray<CodeBlock*> m_currentlyExecuting;
+ Vector<CodeBlock*> m_currentlyExecuting;
};
} // namespace JSC
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (179358 => 179359)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2015-01-29 20:49:13 UTC (rev 179358)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2015-01-29 20:56:16 UTC (rev 179359)
@@ -317,7 +317,6 @@
, m_slotVisitor(m_sharedData)
, m_copyVisitor(m_sharedData)
, m_handleSet(vm)
- , m_codeBlocks()
, m_isSafeToCollect(false)
, m_writeBarrierBuffer(256)
, m_vm(vm)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
