Title: [179362] trunk/Source/WebCore
- Revision
- 179362
- Author
- [email protected]
- Date
- 2015-01-29 13:43:05 -0800 (Thu, 29 Jan 2015)
Log Message
Remove an extraneous check from the parser of :not()
https://bugs.webkit.org/show_bug.cgi?id=141021
Patch by Benjamin Poulain <[email protected]> on 2015-01-29
Reviewed by Darin Adler.
* css/CSSGrammar.y.in:
:not() takes a selector list, it can be null if there selector list is invalid,
but there cannot be a invalid pointer.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (179361 => 179362)
--- trunk/Source/WebCore/ChangeLog 2015-01-29 21:41:32 UTC (rev 179361)
+++ trunk/Source/WebCore/ChangeLog 2015-01-29 21:43:05 UTC (rev 179362)
@@ -1,3 +1,14 @@
+2015-01-29 Benjamin Poulain <[email protected]>
+
+ Remove an extraneous check from the parser of :not()
+ https://bugs.webkit.org/show_bug.cgi?id=141021
+
+ Reviewed by Darin Adler.
+
+ * css/CSSGrammar.y.in:
+ :not() takes a selector list, it can be null if there selector list is invalid,
+ but there cannot be a invalid pointer.
+
2015-01-29 Tim Horton <[email protected]>
Fix the iOS build after r179347
Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (179361 => 179362)
--- trunk/Source/WebCore/css/CSSGrammar.y.in 2015-01-29 21:41:32 UTC (rev 179361)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in 2015-01-29 21:43:05 UTC (rev 179362)
@@ -1506,9 +1506,9 @@
// Definition of :not().
| ':' NOTFUNCTION maybe_space nested_selector_list maybe_space ')' {
$$ = nullptr;
- if ($4 != invalidSelectorVector) {
+ if ($4) {
std::unique_ptr<Vector<std::unique_ptr<CSSParserSelector>>> list($4);
- if (list && selectorListDoesNotMatchAnyPseudoElement(list.get())) {
+ if (selectorListDoesNotMatchAnyPseudoElement(list.get())) {
auto selector = std::make_unique<CSSParserSelector>();
selector->setMatch(CSSSelector::PseudoClass);
selector->setPseudoClassValue($2);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
