Title: [179572] trunk/LayoutTests
- Revision
- 179572
- Author
- [email protected]
- Date
- 2015-02-03 15:02:40 -0800 (Tue, 03 Feb 2015)
Log Message
http/tests/xmlhttprequest/event-listener-gc.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33342
Reviewed by Zalan Bujtas.
This failure means that the GC timer fires after readystatechange event. As a
speculative fix, start the timer before starting the load, so that it's certain to
finish earlier.
* http/tests/xmlhttprequest/event-listener-gc.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (179571 => 179572)
--- trunk/LayoutTests/ChangeLog 2015-02-03 22:22:06 UTC (rev 179571)
+++ trunk/LayoutTests/ChangeLog 2015-02-03 23:02:40 UTC (rev 179572)
@@ -1,3 +1,16 @@
+2015-02-03 Alexey Proskuryakov <[email protected]>
+
+ http/tests/xmlhttprequest/event-listener-gc.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=33342
+
+ Reviewed by Zalan Bujtas.
+
+ This failure means that the GC timer fires after readystatechange event. As a
+ speculative fix, start the timer before starting the load, so that it's certain to
+ finish earlier.
+
+ * http/tests/xmlhttprequest/event-listener-gc.html:
+
2015-02-03 Brent Fulgham <[email protected]>
[Win] Mark some debug assertion failures to be skipped.
Modified: trunk/LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html (179571 => 179572)
--- trunk/LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html 2015-02-03 22:22:06 UTC (rev 179571)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html 2015-02-03 23:02:40 UTC (rev 179572)
@@ -30,13 +30,15 @@
testRunner.dumpAsText();
testRunner.waitUntilDone();
}
-
+
+ // Timeout ensures stack references to request are cleared when we collect.
+ // Start the timer before starting the load, so that it's guaranteed to fire first.
+ setTimeout('collect();', 0);
+
var request = new XMLHttpRequest();
request._onreadystatechange_ = processStateChange;
request.open("GET", "print-content-type.cgi", true);
request.send(null);
-
- setTimeout('collect();', 0); // timeout ensures stack references to request are cleared when we collect
}
</script>
</head>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
