[webkit-changes] [179601] trunk/Source/WebCore

Wed, 04 Feb 2015 08:35:13 -0800

Title: [179601] trunk/Source/WebCore
Revision
179601
Author
[email protected]
Date
2015-02-04 08:34:27 -0800 (Wed, 04 Feb 2015)

Log Message

REGRESSION: AirPlay button not visible but present in inline toolbar
https://bugs.webkit.org/show_bug.cgi?id=141244
<rdar://problem/19328322>

Reviewed by Eric Carlson.

Replace the use of mask-image with a background-image (which matches
what the other buttons are doing).

* Modules/mediacontrols/mediaControlsiOS.css:
(::-webkit-media-controls):
(video::-webkit-media-controls-wireless-playback-picker-button):
(audio::-webkit-media-controls-wireless-playback-picker-button):
(video::-webkit-media-controls-wireless-playback-picker-button.active):
(audio::-webkit-media-controls-wireless-playback-picker-button.active):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (179600 => 179601)


--- trunk/Source/WebCore/ChangeLog	2015-02-04 08:39:25 UTC (rev 179600)
+++ trunk/Source/WebCore/ChangeLog	2015-02-04 16:34:27 UTC (rev 179601)
@@ -1,3 +1,21 @@
+2015-02-04  Dean Jackson  <[email protected]>
+
+        REGRESSION: AirPlay button not visible but present in inline toolbar
+        https://bugs.webkit.org/show_bug.cgi?id=141244
+        <rdar://problem/19328322>
+
+        Reviewed by Eric Carlson.
+
+        Replace the use of mask-image with a background-image (which matches
+        what the other buttons are doing).
+
+        * Modules/mediacontrols/mediaControlsiOS.css:
+        (::-webkit-media-controls):
+        (video::-webkit-media-controls-wireless-playback-picker-button):
+        (audio::-webkit-media-controls-wireless-playback-picker-button):
+        (video::-webkit-media-controls-wireless-playback-picker-button.active):
+        (audio::-webkit-media-controls-wireless-playback-picker-button.active):
+
 2015-02-04  Chris Dumez  <[email protected]>
 
         Add removeFirst(value) / removeAll(value) methods to WTF::Vector

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (179600 => 179601)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css	2015-02-04 08:39:25 UTC (rev 179600)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css	2015-02-04 16:34:27 UTC (rev 179601)
@@ -86,27 +86,29 @@
 audio::-webkit-media-controls-wireless-playback-picker-button,
 video::-webkit-media-controls-wireless-playback-picker-button {
     display: block;
-    background-color: black;
-    -webkit-mask-repeat: no-repeat;
-    -webkit-mask-position: 0 1px;
+    opacity: 0.9;
 }
 
 audio::-webkit-media-controls-wireless-playback-picker-button {
     width: 44px;
     height: 39px;
-    -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 39"><g fill="none"><path stroke="white" stroke-width="1" d="M15.5,24.5  10.5,24.5  10.5,11.5  31.5,11.5  31.5,24.5  26.5,24.5  31.5,24.5  31.5,11.5  10.5,11.5  10.5,24.5  15.5,24.5 Z" /><path fill="white" d="M21,21  13.5,29  28.5,29" /></g></svg>');
+    background-size: 44px 39px;
+    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 39"><g fill="none"><path stroke="black" stroke-width="1" d="M15.5,24.5  10.5,24.5  10.5,11.5  31.5,11.5  31.5,24.5  26.5,24.5  31.5,24.5  31.5,11.5  10.5,11.5  10.5,24.5  15.5,24.5 Z" /><path fill="black" d="M21,21  13.5,29  28.5,29" /></g></svg>');
 }
 
 video::-webkit-media-controls-wireless-playback-picker-button {
     width: 42px;
     height: 44px;
-    -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 42 44"><g fill="none"><path stroke="white" stroke-width="1" d="M15,27.5  10.5,27.5  10.5,14.5  30.5,14.5  30.5,27.5  26,27.5  30.5,27.5  30.5,14.5  10.5,14.5  10.5,27.5  15,27.5 Z" /><path fill="white" d="M20.5,23.5  13,31.5  28,31.5" /></g></svg>');
-    opacity: 0.5;
+    background-size: 42px 44px;
+    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 42 44"><g fill="none"><path stroke="black" stroke-width="1" d="M15,27.5  10.5,27.5  10.5,14.5  30.5,14.5  30.5,27.5  26,27.5  30.5,27.5  30.5,14.5  10.5,14.5  10.5,27.5  15,27.5 Z" /><path fill="black" d="M20.5,23.5  13,31.5  28,31.5" /></g></svg>');
 }
 
-video::-webkit-media-controls-wireless-playback-picker-button.active,
+video::-webkit-media-controls-wireless-playback-picker-button.active {
+    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 42 44"><g fill="none"><path stroke="#1060FE" stroke-width="1" d="M15,27.5  10.5,27.5  10.5,14.5  30.5,14.5  30.5,27.5  26,27.5  30.5,27.5  30.5,14.5  10.5,14.5  10.5,27.5  15,27.5 Z" /><path fill="#1060FE" d="M20.5,23.5  13,31.5  28,31.5" /></g></svg>');
+}
+
 audio::-webkit-media-controls-wireless-playback-picker-button.active {
-    background-color: #1060FE;
+    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 39"><g fill="none"><path stroke="#1060FE" stroke-width="1" d="M15.5,24.5  10.5,24.5  10.5,11.5  31.5,11.5  31.5,24.5  26.5,24.5  31.5,24.5  31.5,11.5  10.5,11.5  10.5,24.5  15.5,24.5 Z" /><path fill="#1060FE" d="M21,21  13.5,29  28.5,29" /></g></svg>');
 }
 
 video::-webkit-media-text-track-container,

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to