Title: [179608] trunk/Tools
Revision
179608
Author
[email protected]
Date
2015-02-04 10:00:00 -0800 (Wed, 04 Feb 2015)

Log Message

When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
https://bugs.webkit.org/show_bug.cgi?id=141236

Reviewed by Sam Weinig.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
(BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js (179607 => 179608)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js	2015-02-04 17:59:01 UTC (rev 179607)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js	2015-02-04 18:00:00 UTC (rev 179608)
@@ -65,7 +65,7 @@
                         var leaksViewerURL = iteration.resultURLs["view leaks"];
                         var status = new StatusLineView(messageElement, StatusLineView.Status.Neutral, leakCount === 1 ? "unique leak" : "unique leaks", leakCount, leaksViewerURL);
                     } else
-                        var status = new StatusLineView(messageElement, StatusLineView.Status.Good, iteration.text, null, buildPageURL);
+                        var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, null, buildPageURL);
                 } else {
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, null, buildPageURL);

Modified: trunk/Tools/ChangeLog (179607 => 179608)


--- trunk/Tools/ChangeLog	2015-02-04 17:59:01 UTC (rev 179607)
+++ trunk/Tools/ChangeLog	2015-02-04 18:00:00 UTC (rev 179608)
@@ -1,3 +1,13 @@
+2015-02-04  Alexey Proskuryakov  <[email protected]>
+
+        When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
+        https://bugs.webkit.org/show_bug.cgi?id=141236
+
+        Reviewed by Sam Weinig.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
+        (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
+
 2015-02-04  Chris Dumez  <[email protected]>
 
         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to