Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (179649 => 179650)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
@@ -103,7 +103,7 @@
var status = new StatusLineView(message, StatusLineView.Status.Good, firstRecentUnsuccessfulIteration ? "last successful build" : "latest build", null, url);
this.element.appendChild(status.element);
} else {
- var status = new StatusLineView("unknown", StatusLineView.Status.Neutral, firstRecentUnsuccessfulIteration ? "last successful build" : "latest build");
+ var status = new StatusLineView("unknown", StatusLineView.Status.Neutral, firstRecentUnsuccessfulIteration ? "last successful build" : "latest build");
this.element.appendChild(status.element);
if (firstRecentUnsuccessfulIteration) {
@@ -113,27 +113,13 @@
}
}
- function appendBuildArchitecture(queues, label)
- {
- queues.forEach(function(queue) {
- var releaseLabel = document.createElement("a");
- releaseLabel.classList.add("queueLabel");
- releaseLabel.textContent = label;
- releaseLabel.href = ""
- releaseLabel.target = "_blank";
- this.element.appendChild(releaseLabel);
+ this.appendBuildStyle.call(this, this.universalReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (Universal)" : "Release", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.sixtyFourBitReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (64-bit)" : "Release", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.thirtyTwoBitReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (32-bit)" : "Release", appendBuilderQueueStatus);
- appendBuilderQueueStatus.call(this, queue);
- }.bind(this));
- }
-
- appendBuildArchitecture.call(this, this.universalReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (Universal)" : "Release");
- appendBuildArchitecture.call(this, this.sixtyFourBitReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (64-bit)" : "Release");
- appendBuildArchitecture.call(this, this.thirtyTwoBitReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (32-bit)" : "Release");
-
- appendBuildArchitecture.call(this, this.universalDebugQueues, this.hasMultipleDebugBuilds ? "Debug (Universal)" : "Debug");
- appendBuildArchitecture.call(this, this.sixtyFourBitDebugQueues, this.hasMultipleDebugBuilds ? "Debug (64-bit)" : "Debug");
- appendBuildArchitecture.call(this, this.thirtyTwoBitDebugQueues, this.hasMultipleDebugBuilds ? "Debug (32-bit)" : "Debug");
+ this.appendBuildStyle.call(this, this.universalDebugQueues, this.hasMultipleDebugBuilds ? "Debug (Universal)" : "Debug", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.sixtyFourBitDebugQueues, this.hasMultipleDebugBuilds ? "Debug (64-bit)" : "Debug", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.thirtyTwoBitDebugQueues, this.hasMultipleDebugBuilds ? "Debug (32-bit)" : "Debug", appendBuilderQueueStatus);
},
_presentPopoverFailureLogs: function(element, popover, iteration)
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (179649 => 179650)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-02-05 00:37:36 UTC (rev 179650)
@@ -227,6 +227,7 @@
testResults.uniqueLeakCount = testStep.results[1].reduce(resultSummarizer.bind(null, "unique leak"), undefined);
testResults.newPassesCount = testStep.results[1].reduce(resultSummarizer.bind(null, "new pass"), undefined);
testResults.missingCount = testStep.results[1].reduce(resultSummarizer.bind(null, "missing"), undefined);
+ testResults.crashCount = testStep.results[1].reduce(resultSummarizer.bind(null, "crash"), undefined);
if (!testResults.failureCount && !testResults.flakyCount && !testResults.totalLeakCount && !testResults.uniqueLeakCount && !testResults.newPassesCount && !testResults.missingCount) {
// This step exited with a non-zero exit status, but we didn't find any output about the number of failed tests.
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js (179649 => 179650)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
@@ -84,21 +84,7 @@
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLeaksQueue.bind(this), iteration);
}
- function appendBuild(queues, label)
- {
- queues.forEach(function(queue) {
- var releaseLabel = document.createElement("a");
- releaseLabel.classList.add("queueLabel");
- releaseLabel.textContent = queue.LeaksTestName ? queue.LeaksTestName : label;
- releaseLabel.href = ""
- releaseLabel.target = "_blank";
- this.element.appendChild(releaseLabel);
-
- appendLeaksQueueStatus.call(this, queue);
- }.bind(this));
- }
-
- appendBuild.call(this, this.releaseQueues, "Leaks");
+ this.appendBuildStyle.call(this, this.releaseQueues, "Leaks", appendLeaksQueueStatus);
},
addLinkToRow: function(rowElement, className, text, url)
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js (179649 => 179650)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
@@ -82,21 +82,7 @@
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForPerformanceQueue.bind(this), queue);
}
- function appendBuild(queues, label)
- {
- queues.forEach(function(queue) {
- var releaseLabel = document.createElement("a");
- releaseLabel.classList.add("queueLabel");
- releaseLabel.textContent = queue.performanceTestName ? queue.performanceTestName : label;
- releaseLabel.href = ""
- releaseLabel.target = "_blank";
- this.element.appendChild(releaseLabel);
-
- appendPerformanceQueueStatus.call(this, queue);
- }.bind(this));
- }
-
- appendBuild.call(this, this.releaseQueues, 'Release');
+ this.appendBuildStyle.call(this, this.releaseQueues, 'Release', appendPerformanceQueueStatus);
},
addLinkToRow: function(rowElement, className, text, url)
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (179649 => 179650)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2015-02-05 00:37:36 UTC (rev 179650)
@@ -42,7 +42,8 @@
this.leaks = info.leaks || false;
this.architecture = info.architecture || null;
this.testCategory = info.testCategory || null;
- this.performanceTestName = info.performanceTestName || null;
+ this.heading = info.heading || null;
+ this.crashesOnly = info.crashesOnly || false;
this.iterations = [];
this._knownIterations = {};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (179649 => 179650)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
@@ -286,6 +286,20 @@
return fragment;
},
+ appendBuildStyle: function(queues, defaultLabel, appendFunction)
+ {
+ queues.forEach(function(queue) {
+ var releaseLabel = document.createElement("a");
+ releaseLabel.classList.add("queueLabel");
+ releaseLabel.textContent = queue.heading ? queue.heading : defaultLabel;
+ releaseLabel.href = ""
+ releaseLabel.target = "_blank";
+ this.element.appendChild(releaseLabel);
+
+ appendFunction.call(this, queue);
+ }.bind(this));
+ },
+
_updateQueues: function()
{
this.releaseQueues.forEach(function(queue) { queue.update(); });
@@ -316,4 +330,5 @@
{
this.updateSoon();
}
+
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js (179649 => 179650)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js 2015-02-05 00:37:36 UTC (rev 179650)
@@ -39,6 +39,7 @@
this.uniqueLeakCount = info.uniqueLeakCount || 0;
this.newPassesCount = info.newPassesCount || 0;
this.missingCount = info.missingCount || 0;
+ this.crashCount = info.crashCount || 0;
};
BaseObject.addConstructorFunctions(BuildbotTestResults);
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (179649 => 179650)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
@@ -79,6 +79,13 @@
} else if (!iteration.productive) {
var url = ""
var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
+ } else if (queue.crashesOnly && !iteration.crashCount) {
+ var url = ""
+ var status = new StatusLineView(messageElement, StatusLineView.Status.Good, "no crashes found", undefined, url);
+ } else if (queue.crashesOnly && iteration.crashCount) {
+ var url = ""
+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "crash found" : "crashes found", undefined, url);
+ new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
} else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.errorOccurred && !bindingTestResults.errorOccurred) {
// Something wrong happened, but it was not a test failure.
var url = ""
@@ -122,22 +129,8 @@
}
}
- function appendBuild(queues, label)
- {
- queues.forEach(function(queue) {
- var releaseLabel = document.createElement("a");
- releaseLabel.classList.add("queueLabel");
- releaseLabel.textContent = label;
- releaseLabel.href = ""
- releaseLabel.target = "_blank";
- this.element.appendChild(releaseLabel);
-
- appendBuilderQueueStatus.call(this, queue);
- }.bind(this));
- }
-
- appendBuild.call(this, this.releaseQueues, "Release");
- appendBuild.call(this, this.debugQueues, "Debug");
+ this.appendBuildStyle.call(this, this.releaseQueues, "Release", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.debugQueues, "Debug", appendBuilderQueueStatus);
},
_popoverContentForLayoutTestRegressions: function(iteration)
Modified: trunk/Tools/ChangeLog (179649 => 179650)
--- trunk/Tools/ChangeLog 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/ChangeLog 2015-02-05 00:37:36 UTC (rev 179650)
@@ -1,3 +1,36 @@
+2015-02-04 Dana Burkart <[email protected]>
+
+ Botwatcher's Dashboard is cramped
+ https://bugs.webkit.org/show_bug.cgi?id=140273
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add a heading key which will allow for arbitrary headings in builder queues.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+ (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
+ (BuildbotBuilderQueueView.prototype.update):
+ (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype._parseData):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
+ (BuildbotLeaksQueueView.prototype.update):
+ (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
+ (BuildbotPerformanceQueueView.prototype.update):
+ (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ (BuildbotQueue):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ (BuildbotQueueView.prototype._unauthorizedAccess):
+ (BuildbotQueueView.prototype._appendBuild):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
+ (BuildbotTestResults):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+ (BuildbotTesterQueueView.prototype.update):
+ (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
+
2015-02-04 Simon Fraser <[email protected]>
WKTR should not use -mainScreen to pick a color profile
