Title: [179654] trunk/Source/_javascript_Core
- Revision
- 179654
- Author
- [email protected]
- Date
- 2015-02-04 17:05:49 -0800 (Wed, 04 Feb 2015)
Log Message
Undo gardening: Restoring the expected ERROR message since that is not the cause of the bot unhappiness.
Not reviewed.
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::tryCopyOtherThreadStacks):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (179653 => 179654)
--- trunk/Source/_javascript_Core/ChangeLog 2015-02-05 00:57:30 UTC (rev 179653)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-02-05 01:05:49 UTC (rev 179654)
@@ -1,5 +1,14 @@
2015-02-04 Mark Lam <[email protected]>
+ Undo gardening: Restoring the expected ERROR message since that is not the cause of the bot unhappiness.
+
+ Not reviewed.
+
+ * heap/MachineStackMarker.cpp:
+ (JSC::MachineThreads::tryCopyOtherThreadStacks):
+
+2015-02-04 Mark Lam <[email protected]>
+
Gardening: Changed expected ERROR message to WARNING to make test bots happy.
Rubber stamped by Simon Fraser.
Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (179653 => 179654)
--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2015-02-05 00:57:30 UTC (rev 179653)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2015-02-05 01:05:49 UTC (rev 179654)
@@ -467,7 +467,8 @@
kern_return_t error = thread_suspend(thread->platformThread);
ASSERT(error != KERN_SUCCESS);
- WTFLogAlways("WARNING: _javascript_ garbage collection encountered an invalid thread (err 0x%x): Thread [%d/%d: %p] platformThread %p.",
+ WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION,
+ "_javascript_ garbage collection encountered an invalid thread (err 0x%x): Thread [%d/%d: %p] platformThread %p.",
error, index, numberOfThreads, thread, reinterpret_cast<void*>(thread->platformThread));
// Put the invalid thread on the threadsToBeDeleted list.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
