Modified: branches/safari-600.1.4.15-branch/LayoutTests/ChangeLog (179684 => 179685)
--- branches/safari-600.1.4.15-branch/LayoutTests/ChangeLog 2015-02-05 09:25:03 UTC (rev 179684)
+++ branches/safari-600.1.4.15-branch/LayoutTests/ChangeLog 2015-02-05 09:25:50 UTC (rev 179685)
@@ -2,6 +2,20 @@
Merge r178953
+ 2015-01-21 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType
+ https://bugs.webkit.org/show_bug.cgi?id=140746
+
+ Reviewed by Timothy Hatcher.
+
+ * TestExpectations:
+ Unskip the test now that is doesn't ASSERT in debug builds.
+
+2015-02-05 Lucas Forschler <[email protected]>
+
+ Merge r178953
+
2015-01-22 Joseph Pecoraro <[email protected]>
Unreviewed, skip flakey inspector test.
Modified: branches/safari-600.1.4.15-branch/Source/_javascript_Core/ChangeLog (179684 => 179685)
--- branches/safari-600.1.4.15-branch/Source/_javascript_Core/ChangeLog 2015-02-05 09:25:03 UTC (rev 179684)
+++ branches/safari-600.1.4.15-branch/Source/_javascript_Core/ChangeLog 2015-02-05 09:25:50 UTC (rev 179685)
@@ -1,5 +1,20 @@
2015-02-05 Lucas Forschler <[email protected]>
+ Merge r178953
+
+ 2015-01-21 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType
+ https://bugs.webkit.org/show_bug.cgi?id=140746
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/InjectedScriptSource.js:
+ Do not add impure properties to the descriptor object that will
+ eventually be sent to the frontend.
+
+2015-02-05 Lucas Forschler <[email protected]>
+
Merge r178768
2015-01-20 Joseph Pecoraro <[email protected]>
Modified: branches/safari-600.1.4.15-branch/Source/_javascript_Core/inspector/InjectedScriptSource.js (179684 => 179685)
--- branches/safari-600.1.4.15-branch/Source/_javascript_Core/inspector/InjectedScriptSource.js 2015-02-05 09:25:03 UTC (rev 179684)
+++ branches/safari-600.1.4.15-branch/Source/_javascript_Core/inspector/InjectedScriptSource.js 2015-02-05 09:25:50 UTC (rev 179685)
@@ -626,7 +626,7 @@
function createFakeValueDescriptor(name, descriptor, isOwnProperty)
{
try {
- return {name: name, value: object[name], writable: descriptor.writable, configurable: descriptor.configurable, enumerable: descriptor.enumerable};
+ return {name: name, value: object[name], writable: descriptor.writable || false, configurable: descriptor.configurable || false, enumerable: descriptor.enumerable || false};
} catch (e) {
var errorDescriptor = {name: name, value: e, wasThrown: true};
if (isOwnProperty)
@@ -635,7 +635,7 @@
}
}
- function processDescriptor(descriptor, isOwnProperty)
+ function processDescriptor(descriptor, isOwnProperty, possibleNativeBindingGetter)
{
// Own properties only.
if (ownProperties) {
@@ -652,7 +652,7 @@
} else if (descriptor.hasOwnProperty("get") && descriptor.get) {
// Getter property in the prototype chain. Create a fake value descriptor.
descriptors.push(createFakeValueDescriptor(descriptor.name, descriptor, isOwnProperty));
- } else if (descriptor.possibleNativeBindingGetter) {
+ } else if (possibleNativeBindingGetter) {
// Possible getter property in the prototype chain.
descriptors.push(descriptor);
}
@@ -686,8 +686,7 @@
// Developers may create such a descriptors, so we should be resilient:
// var x = {}; Object.defineProperty(x, "p", {get:undefined}); Object.getOwnPropertyDescriptor(x, "p")
var fakeDescriptor = createFakeValueDescriptor(name, descriptor, isOwnProperty);
- fakeDescriptor.possibleNativeBindingGetter = true; // Native bindings.
- processDescriptor(fakeDescriptor, isOwnProperty);
+ processDescriptor(fakeDescriptor, isOwnProperty, true);
continue;
}
