Title: [179729] trunk/Websites/perf.webkit.org
- Revision
- 179729
- Author
- [email protected]
- Date
- 2015-02-05 17:14:40 -0800 (Thu, 05 Feb 2015)
Log Message
Move commits viewer to the end of details view
https://bugs.webkit.org/show_bug.cgi?id=141315
Reviewed by Andreas Kling.
Improved the way list of commits are shown per kling's request.
* public/v2/app.js:
(App.PaneController._updateDetails): Always show the old value even when a single point is selected.
* public/v2/chart-pane.css: Updated the style for the commits viewer.
* public/v2/commits-viewer.js:
(App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
(App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
* public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
moved the commits viewers out of the details tables so that they don't interleave revision data.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (179728 => 179729)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-06 01:14:40 UTC (rev 179729)
@@ -1,5 +1,26 @@
2015-02-05 Ryosuke Niwa <[email protected]>
+ Move commits viewer to the end of details view
+ https://bugs.webkit.org/show_bug.cgi?id=141315
+
+ Reviewed by Andreas Kling.
+
+ Improved the way list of commits are shown per kling's request.
+
+ * public/v2/app.js:
+ (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
+
+ * public/v2/chart-pane.css: Updated the style for the commits viewer.
+
+ * public/v2/commits-viewer.js:
+ (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
+ (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
+
+ * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
+ moved the commits viewers out of the details tables so that they don't interleave revision data.
+
+2015-02-05 Ryosuke Niwa <[email protected]>
+
New perf dashboard should compare results to baseline and target
https://bugs.webkit.org/show_bug.cgi?id=141286
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (179728 => 179729)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-06 01:14:40 UTC (rev 179729)
@@ -766,7 +766,7 @@
this.set('details', Ember.Object.create({
status: this._computeStatus(currentPoint),
currentValue: chartData.formatter(currentMeasurement.mean()),
- oldValue: oldMeasurement && selectedPoints ? chartData.formatter(oldMeasurement.mean()) : null,
+ oldValue: oldMeasurement ? chartData.formatter(oldMeasurement.mean()) : null,
buildNumber: buildNumber,
buildURL: buildURL,
buildTime: currentMeasurement.formattedBuildTime(),
Modified: trunk/Websites/perf.webkit.org/public/v2/chart-pane.css (179728 => 179729)
--- trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-02-06 01:14:40 UTC (rev 179729)
@@ -175,7 +175,7 @@
overflow: scroll;
}
-.analysis-chart-pane .details table {
+.analysis-chart-pane table {
margin: 0.5rem;
}
@@ -192,7 +192,8 @@
overflow: scroll;
}
-.chart-pane .details-table {
+.chart-pane .details-table,
+.chart-pane .commits-viewer {
font-size: 0.8rem;
width: 100%;
table-layout: fixed;
@@ -203,28 +204,17 @@
padding-right: 1px;
}
-.chart-pane .details-table td table {
- border-collapse: collapse;
-}
-
-.chart-pane .details-table td table td {
- word-break: break-word;
- border-top: solid 1px #ccc;
- border-bottom: solid 1px #ccc;
- padding: 0.2rem;
-}
-
-.chart-pane .details-table td table td a {
- text-decoration: none;
-}
-
.chart-pane .details-table th {
- width: 7rem;
+ width: 30%;
text-align: right;
font-weight: normal;
padding: 0;
}
+.chart-pane .details-table td {
+ width: 70%;
+}
+
.chart-pane .details-table .bugs th {
font-weight: bold;
}
@@ -241,6 +231,52 @@
font-size: 1rem;
}
+.chart-pane .commits-viewer caption {
+ border-top: solid 1px #ccc;
+ font-weight: normal;
+ text-align: left;
+ padding: 0.2rem;
+ padding-left: 0.5rem;
+ cursor: pointer;
+}
+
+.chart-pane .commits-viewer caption:before {
+ display: inline-block;
+ width: 0.8rem;
+ content: "\25BE"; /* Down arrow */
+}
+
+.chart-pane .commits-viewer.hidden caption:before {
+ display: inline-block;
+ width: 0.8rem;
+ content: "\25B8"; /* Right arrow */
+}
+
+.chart-pane .commits {
+ border-bottom: solid 1px #ccc;
+ margin-bottom: 0.2rem;
+}
+
+.chart-pane .commits-viewer {
+ border-collapse: collapse;
+}
+
+.chart-pane .commits-viewer td,
+.chart-pane .commits-viewer th {
+ word-break: break-word;
+ border-top: solid 1px #ccc;
+ padding: 0.2rem;
+}
+
+.chart-pane .commits-viewer th {
+ width: 20%;
+ font-weight: normal;
+}
+
+.chart-pane .commits-viewer td {
+ width: 60%;
+}
+
.chart-pane .chart {
height: 100%;
}
Modified: trunk/Websites/perf.webkit.org/public/v2/commits-viewer.js (179728 => 179729)
--- trunk/Websites/perf.webkit.org/public/v2/commits-viewer.js 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/public/v2/commits-viewer.js 2015-02-06 01:14:40 UTC (rev 179729)
@@ -2,6 +2,7 @@
repository: null,
revisionInfo: null,
commits: null,
+ visible: true,
commitsChanged: function ()
{
var revisionInfo = this.get('revisionInfo');
@@ -30,4 +31,10 @@
self.set('commits', []);
})
}.observes('repository').observes('revisionInfo').on('init'),
+ actions: {
+ toggleVisibility: function ()
+ {
+ this.toggleProperty('visible');
+ }
+ }
});
Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (179728 => 179729)
--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-06 01:14:40 UTC (rev 179729)
@@ -269,6 +269,7 @@
</td>
</tr>
</tbody>
+ <tbody>
{{#if details.buildNumber}}
<tr>
<th>Build</th>
@@ -293,31 +294,40 @@
{{/if}}
</td>
</tr>
- <tr>
- <td colspan="2">{{commits-viewer repository=repository revisionInfo=this}}</td>
- </tr>
{{/each}}
+ </tbody>
</table>
+ <div class="commits">
+ {{#each details.revisions}}
+ {{commits-viewer repository=repository revisionInfo=this caption=name}}
+ {{/each}}
+ </div>
</div>
</script>
<script type="text/x-handlebars" data-template-name="components/commits-viewer">
{{#if commits}}
- <table>
- <tbody>
- {{#each commits}}
- <tr>
- <td>
- {{#if url}}
- <a {{bind-attr href="" target="_blank">{{author}}</a>
- {{else}}
- {{author}}
- {{/if}}
- </td>
- <td>{{message}}</td>
- </tr>
- {{/each}}
- </tbody>
+ <table {{bind-attr class=":commits-viewer visible::hidden"}}>
+ {{#if caption}}
+ <caption {{action toggleVisibility}}>{{caption}} commits</caption>
+ {{/if}}
+ {{#if visible}}
+ <tbody>
+ {{#each commits}}
+ <tr>
+ <th>
+ {{#if url}}
+ <a {{bind-attr href="" target="_blank">{{revision}}</a>
+ {{else}}
+ {{revision}}
+ {{/if}}
+ </th>
+ <th>{{author}}</th>
+ <td>{{message}}</td>
+ </tr>
+ {{/each}}
+ </tbody>
+ {{/if}}
</table>
{{/if}}
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
