Title: [179731] trunk/Websites/perf.webkit.org
- Revision
- 179731
- Author
- [email protected]
- Date
- 2015-02-05 17:23:31 -0800 (Thu, 05 Feb 2015)
Log Message
Move commits viewer to the end of details view
https://bugs.webkit.org/show_bug.cgi?id=141315
Rubber-stamped by Andreas Kling.
Show the difference instead of the old value per kling's request.
* public/v2/app.js:
(App.PaneController._updateDetails):
* public/v2/index.html:
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (179730 => 179731)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-06 01:15:51 UTC (rev 179730)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-06 01:23:31 UTC (rev 179731)
@@ -3,6 +3,19 @@
Move commits viewer to the end of details view
https://bugs.webkit.org/show_bug.cgi?id=141315
+ Rubber-stamped by Andreas Kling.
+
+ Show the difference instead of the old value per kling's request.
+
+ * public/v2/app.js:
+ (App.PaneController._updateDetails):
+ * public/v2/index.html:
+
+2015-02-05 Ryosuke Niwa <[email protected]>
+
+ Move commits viewer to the end of details view
+ https://bugs.webkit.org/show_bug.cgi?id=141315
+
Reviewed by Andreas Kling.
Improved the way list of commits are shown per kling's request.
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (179730 => 179731)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-06 01:15:51 UTC (rev 179730)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-06 01:23:31 UTC (rev 179731)
@@ -763,10 +763,14 @@
}
var chartData = this.get('chartData');
+ var valueDiff = oldMeasurement ? chartData.formatter(currentMeasurement.mean() - oldMeasurement.mean()) : null;
+ if (valueDiff && valueDiff > 0)
+ valueDiff = '+' + valueDiff;
+
this.set('details', Ember.Object.create({
status: this._computeStatus(currentPoint),
currentValue: chartData.formatter(currentMeasurement.mean()),
- oldValue: oldMeasurement ? chartData.formatter(oldMeasurement.mean()) : null,
+ valueDiff: valueDiff,
buildNumber: buildNumber,
buildURL: buildURL,
buildTime: currentMeasurement.formattedBuildTime(),
Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (179730 => 179731)
--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-06 01:15:51 UTC (rev 179730)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-06 01:23:31 UTC (rev 179731)
@@ -259,8 +259,8 @@
<th>Current</th>
<td>
{{details.currentValue}} {{chartData.unit}}
- {{#if details.oldValue}}
- (from {{details.oldValue}} {{chartData.unit}})
+ {{#if details.valueDiff}}
+ ({{details.valueDiff}} {{chartData.unit}})
{{/if}}
{{#if details.status.label}}
<br>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
