Title: [179766] trunk/Websites/perf.webkit.org
- Revision
- 179766
- Author
- [email protected]
- Date
- 2015-02-06 15:31:30 -0800 (Fri, 06 Feb 2015)
Log Message
The delta value in the chart pane sometimes doens't show '+' for a positive delta
https://bugs.webkit.org/show_bug.cgi?id=141340
Reviewed by Andreas Kling.
The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
* public/v2/app.js:
(App.Pane.computeStatus):
(App.createChartData):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (179765 => 179766)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-06 22:55:57 UTC (rev 179765)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-06 23:31:30 UTC (rev 179766)
@@ -1,5 +1,19 @@
2015-02-06 Ryosuke Niwa <[email protected]>
+ The delta value in the chart pane sometimes doens't show '+' for a positive delta
+ https://bugs.webkit.org/show_bug.cgi?id=141340
+
+ Reviewed by Andreas Kling.
+
+ The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
+ it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
+
+ * public/v2/app.js:
+ (App.Pane.computeStatus):
+ (App.createChartData):
+
+2015-02-06 Ryosuke Niwa <[email protected]>
+
Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
* public/v2/app.js:
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (179765 => 179766)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-06 22:55:57 UTC (rev 179765)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-06 23:31:30 UTC (rev 179766)
@@ -406,9 +406,6 @@
label = formatter(Math.abs(diffFromTarget)) + ' until target';
var valueDelta = previousPoint ? chartData.deltaFormatter(currentPoint.value - previousPoint.value) : null;
- if (valueDelta && valueDelta > 0)
- valueDelta = '+' + valueDelta;
-
return {className: className, label: label, currentValue: chartData.formatter(currentPoint.value), valueDelta: valueDelta};
},
_relativeDifferentToLaterPointInTimeSeries: function (currentPoint, timeSeries)
@@ -445,7 +442,7 @@
target: runs.target ? runs.target.timeSeriesByCommitTime() : null,
unit: data.unit,
formatter: data.useSI ? d3.format('.4s') : d3.format('.4g'),
- deltaFormatter: data.useSI ? d3.format('.2s') : d3.format('.2g'),
+ deltaFormatter: data.useSI ? d3.format('+.2s') : d3.format('+.2g'),
smallerIsBetter: data.smallerIsBetter,
};
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
