Title: [179775] trunk/Tools
- Revision
- 179775
- Author
- [email protected]
- Date
- 2015-02-06 20:35:30 -0800 (Fri, 06 Feb 2015)
Log Message
dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
https://bugs.webkit.org/show_bug.cgi?id=141349
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype.update):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (179774 => 179775)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2015-02-07 03:06:58 UTC (rev 179774)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2015-02-07 04:35:30 UTC (rev 179775)
@@ -79,12 +79,12 @@
} else if (!iteration.productive) {
var url = ""
var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
- } else if (queue.crashesOnly && !iteration.crashCount) {
+ } else if (queue.crashesOnly && !layoutTestResults.crashCount) {
var url = ""
var status = new StatusLineView(messageElement, StatusLineView.Status.Good, "no crashes found", undefined, url);
- } else if (queue.crashesOnly && iteration.crashCount) {
+ } else if (queue.crashesOnly && layoutTestResults.crashCount) {
var url = ""
- var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "crash found" : "crashes found", undefined, url);
+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.crashCount === 1 ? "crash found" : "crashes found", layoutTestResults.crashCount, url);
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
} else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.errorOccurred && !bindingTestResults.errorOccurred) {
// Something wrong happened, but it was not a test failure.
Modified: trunk/Tools/ChangeLog (179774 => 179775)
--- trunk/Tools/ChangeLog 2015-02-07 03:06:58 UTC (rev 179774)
+++ trunk/Tools/ChangeLog 2015-02-07 04:35:30 UTC (rev 179775)
@@ -1,3 +1,14 @@
+2015-02-06 Dana Burkart <[email protected]>
+
+ dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
+ https://bugs.webkit.org/show_bug.cgi?id=141349
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+ (BuildbotTesterQueueView.prototype.update):
+
2015-02-06 Alexey Proskuryakov <[email protected]>
Report network process crashes during layout tests
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
