Title: [179787] trunk/LayoutTests
Revision
179787
Author
[email protected]
Date
2015-02-07 16:32:54 -0800 (Sat, 07 Feb 2015)

Log Message

fast/images/animated-gif-iframe-webkit-transform.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=141323

Reviewed by Alexey Proskuryakov.

Use shouldBecomeEqual() instead of shouldBe() to check for initial test
conditions. This should address the flakiness.

* fast/images/animated-gif-iframe-webkit-transform-expected.txt:
* fast/images/animated-gif-iframe-webkit-transform.html:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (179786 => 179787)


--- trunk/LayoutTests/ChangeLog	2015-02-07 23:46:18 UTC (rev 179786)
+++ trunk/LayoutTests/ChangeLog	2015-02-08 00:32:54 UTC (rev 179787)
@@ -1,3 +1,17 @@
+2015-02-07  Chris Dumez  <[email protected]>
+
+        fast/images/animated-gif-iframe-webkit-transform.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=141323
+
+        Reviewed by Alexey Proskuryakov.
+
+        Use shouldBecomeEqual() instead of shouldBe() to check for initial test
+        conditions. This should address the flakiness.
+
+        * fast/images/animated-gif-iframe-webkit-transform-expected.txt:
+        * fast/images/animated-gif-iframe-webkit-transform.html:
+        * platform/mac/TestExpectations:
+
 2015-02-07  Darin Adler  <[email protected]>
 
         Stop dispatching events with SVGElementInstance objects as their targets

Modified: trunk/LayoutTests/fast/images/animated-gif-iframe-webkit-transform-expected.txt (179786 => 179787)


--- trunk/LayoutTests/fast/images/animated-gif-iframe-webkit-transform-expected.txt	2015-02-07 23:46:18 UTC (rev 179786)
+++ trunk/LayoutTests/fast/images/animated-gif-iframe-webkit-transform-expected.txt	2015-02-08 00:32:54 UTC (rev 179787)
@@ -4,9 +4,8 @@
 
 
  
+PASS !isFirstImagePaused() && isSecondImagePaused() became true
 PASS isFirstImagePaused() is false
-PASS isSecondImagePaused() became true
-PASS isFirstImagePaused() is false
 Translating images left so that first image is no longer visible, but second image is.
 PASS isFirstImagePaused() became true
 PASS isSecondImagePaused() became false

Modified: trunk/LayoutTests/fast/images/animated-gif-iframe-webkit-transform.html (179786 => 179787)


--- trunk/LayoutTests/fast/images/animated-gif-iframe-webkit-transform.html	2015-02-07 23:46:18 UTC (rev 179786)
+++ trunk/LayoutTests/fast/images/animated-gif-iframe-webkit-transform.html	2015-02-08 00:32:54 UTC (rev 179787)
@@ -70,8 +70,7 @@
   ++numberFramesLoaded;
   if (numberFramesLoaded != 2)
     return;
-  shouldBeFalse("isFirstImagePaused()");
-  shouldBecomeEqual("isSecondImagePaused()", "true", translateImagesLeft);
+  shouldBecomeEqual("!isFirstImagePaused() && isSecondImagePaused()", "true", translateImagesLeft);
 }
 
 </script>

Modified: trunk/LayoutTests/platform/mac/TestExpectations (179786 => 179787)


--- trunk/LayoutTests/platform/mac/TestExpectations	2015-02-07 23:46:18 UTC (rev 179786)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-02-08 00:32:54 UTC (rev 179787)
@@ -1404,4 +1404,3 @@
 # Sometimes has an extra space at the end
 fast/forms/focus-selection-textarea.html [ Pass Failure ]
 
-webkit.org/b/141323 fast/images/animated-gif-iframe-webkit-transform.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to