Title: [179789] trunk/LayoutTests
- Revision
- 179789
- Author
- [email protected]
- Date
- 2015-02-07 16:53:49 -0800 (Sat, 07 Feb 2015)
Log Message
http/tests/xmlhttprequest/event-listener-gc.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33342
Reviewed by Darin Adler.
This test relies on a zero-delay timer being a lot faster than fetching from network.
Force a layout before starting the test, because otherwise, the layout can significantly
delay the timer (I've seen 50-60 milliseconds being a common delay in debug builds).
Also, changed the resource URL to avoid Apache error log spew.
* http/tests/xmlhttprequest/event-listener-gc.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (179788 => 179789)
--- trunk/LayoutTests/ChangeLog 2015-02-08 00:44:06 UTC (rev 179788)
+++ trunk/LayoutTests/ChangeLog 2015-02-08 00:53:49 UTC (rev 179789)
@@ -1,3 +1,18 @@
+2015-02-07 Alexey Proskuryakov <[email protected]>
+
+ http/tests/xmlhttprequest/event-listener-gc.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=33342
+
+ Reviewed by Darin Adler.
+
+ This test relies on a zero-delay timer being a lot faster than fetching from network.
+ Force a layout before starting the test, because otherwise, the layout can significantly
+ delay the timer (I've seen 50-60 milliseconds being a common delay in debug builds).
+
+ Also, changed the resource URL to avoid Apache error log spew.
+
+ * http/tests/xmlhttprequest/event-listener-gc.html:
+
2015-02-07 Chris Dumez <[email protected]>
fast/images/animated-gif-iframe-webkit-transform.html is flaky
Modified: trunk/LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html (179788 => 179789)
--- trunk/LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html 2015-02-08 00:44:06 UTC (rev 179788)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html 2015-02-08 00:53:49 UTC (rev 179789)
@@ -30,14 +30,16 @@
testRunner.waitUntilDone();
}
- // Timeout ensures stack references to request are cleared when we collect.
- // Start the timer before starting the load, so that it's guaranteed to fire first.
- setTimeout('collect();', 0);
+ // Force layout now, as otherwise it will occur before our garbage collection timer,
+ // possibly delaying it until after XMLHttpRequest finishes.
+ document.body.offsetTop;
var request = new XMLHttpRequest();
request._onreadystatechange_ = processStateChange;
- request.open("GET", "print-content-type.cgi", true);
+ request.open("GET", "resources/print-headers.cgi", true);
request.send(null);
+
+ setTimeout('collect();', 0);
}
</script>
</head>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
