Title: [179821] trunk/Source/WebKit2
- Revision
- 179821
- Author
- [email protected]
- Date
- 2015-02-09 00:02:34 -0800 (Mon, 09 Feb 2015)
Log Message
REGRESSION(r179705): [GTK] The Web Inspector doesn't work after r179705
https://bugs.webkit.org/show_bug.cgi?id=141333
Reviewed by Žan Doberšek.
Create an initialize WebPreferences for the inspector page. This
was moved from cross-platform code to platform specific code.
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (179820 => 179821)
--- trunk/Source/WebKit2/ChangeLog 2015-02-09 07:09:50 UTC (rev 179820)
+++ trunk/Source/WebKit2/ChangeLog 2015-02-09 08:02:34 UTC (rev 179821)
@@ -1,3 +1,16 @@
+2015-02-09 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r179705): [GTK] The Web Inspector doesn't work after r179705
+ https://bugs.webkit.org/show_bug.cgi?id=141333
+
+ Reviewed by Žan Doberšek.
+
+ Create an initialize WebPreferences for the inspector page. This
+ was moved from cross-platform code to platform specific code.
+
+ * UIProcess/gtk/WebInspectorProxyGtk.cpp:
+ (WebKit::WebInspectorProxy::platformCreateInspectorPage):
+
2015-02-08 Timothy Horton <[email protected]>
Null deref in _clearImmediateActionState when closing a view with a DataDetectors popover open
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp (179820 => 179821)
--- trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp 2015-02-09 07:09:50 UTC (rev 179820)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp 2015-02-09 08:02:34 UTC (rev 179821)
@@ -61,9 +61,18 @@
{
ASSERT(inspectedPage());
ASSERT(!m_inspectorView);
- RefPtr<WebPageGroup> pageGroup = WebPageGroup::create(inspectorPageGroupIdentifier(), false, false).leakRef();
- m_inspectorView = GTK_WIDGET(webkitWebViewBaseCreate(&inspectorProcessPool(), nullptr, pageGroup.get(), nullptr, nullptr));
+
+ RefPtr<WebPreferences> preferences = WebPreferences::create(String(), "WebKit2.", "WebKit2.");
+#ifndef NDEBUG
+ // Allow developers to inspect the Web Inspector in debug builds without changing settings.
+ preferences->setDeveloperExtrasEnabled(true);
+ preferences->setLogsPageMessagesToSystemConsoleEnabled(true);
+#endif
+ preferences->setAllowFileAccessFromFileURLs(true);
+ RefPtr<WebPageGroup> pageGroup = WebPageGroup::create(inspectorPageGroupIdentifier(), false, false);
+ m_inspectorView = GTK_WIDGET(webkitWebViewBaseCreate(&inspectorProcessPool(), preferences.get(), pageGroup.get(), nullptr, nullptr));
g_object_add_weak_pointer(G_OBJECT(m_inspectorView), reinterpret_cast<void**>(&m_inspectorView));
+
return webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(m_inspectorView));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
