Modified: trunk/Source/WebKit2/ChangeLog (179827 => 179828)
--- trunk/Source/WebKit2/ChangeLog 2015-02-09 16:22:53 UTC (rev 179827)
+++ trunk/Source/WebKit2/ChangeLog 2015-02-09 16:37:41 UTC (rev 179828)
@@ -1,3 +1,28 @@
+2015-02-09 Brian J. Burg <[email protected]>
+
+ REGRESSION(r179705): 2nd-level inspector availability no longer controlled by DeveloperExtrasEnabled user default
+ https://bugs.webkit.org/show_bug.cgi?id=141343
+
+ Reviewed by Timothy Hatcher.
+
+ The regression was caused by the switch to using WKWebViewConfiguration and
+ its default WebPreferences object, which is used to populate the inspector page's
+ Settings object. This WebPreferences is initialized with no identifier, so
+ only preferences in the FOR_EACH_WEBKIT_DEBUG_*_PREFERENCE macros are populated
+ from NSUserDefaults.
+
+ The simplest fix is to move DeveloperExtrasEnabled into the DEBUG group.
+
+ Previously, each inspector level had a unique identifier such as
+ __WebInspectorPageGroupLevelN__, and the n+1 level inspector was enabled
+ by toggling __WebInspectorPageGroupLevelN__.WebKit2DeveloperExrasEnabled.
+ With the move to the DEBUG group, the preference becomes simply
+ WebKitDeveloperExtrasEnabled, which enables any level of inspector.
+ (This does not clash with Safari's "Show Develop Menu" preference, which uses
+ the key "WebKitDeveloperExtrasEnabledPreferenceKey")
+
+ * Shared/WebPreferencesDefinitions.h:
+
2015-02-08 Antti Koivisto <[email protected]>
Measure cache size more accurately
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (179827 => 179828)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2015-02-09 16:22:53 UTC (rev 179827)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2015-02-09 16:37:41 UTC (rev 179828)
@@ -95,7 +95,6 @@
macro(DatabasesEnabled, databasesEnabled, Bool, bool, true) \
macro(XSSAuditorEnabled, xssAuditorEnabled, Bool, bool, true) \
macro(FrameFlatteningEnabled, frameFlatteningEnabled, Bool, bool, DEFAULT_FRAME_FLATTENING_ENABLED) \
- macro(DeveloperExtrasEnabled, developerExtrasEnabled, Bool, bool, false) \
macro(_javascript_ExperimentsEnabled, _javascript_ExperimentsEnabled, Bool, bool, false) \
macro(PrivateBrowsingEnabled, privateBrowsingEnabled, Bool, bool, false) \
macro(TextAreasAreResizable, textAreasAreResizable, Bool, bool, DEFAULT_TEXT_AREAS_ARE_RESIZABLE) \
@@ -226,6 +225,7 @@
macro(CompositingRepaintCountersVisible, compositingRepaintCountersVisible, Bool, bool, false) \
macro(TiledScrollingIndicatorVisible, tiledScrollingIndicatorVisible, Bool, bool, false) \
macro(SimpleLineLayoutDebugBordersEnabled, simpleLineLayoutDebugBordersEnabled, Bool, bool, false) \
+ macro(DeveloperExtrasEnabled, developerExtrasEnabled, Bool, bool, false) \
macro(LogsPageMessagesToSystemConsoleEnabled, logsPageMessagesToSystemConsoleEnabled, Bool, bool, false) \
macro(IgnoreViewportScalingConstraints, ignoreViewportScalingConstraints, Bool, bool, false) \
\
