Title: [179874] trunk/Source/WebKit2
- Revision
- 179874
- Author
- [email protected]
- Date
- 2015-02-10 11:11:44 -0800 (Tue, 10 Feb 2015)
Log Message
[Cocoa] NSData over retain in WKBrowsingContextController loadData
https://bugs.webkit.org/show_bug.cgi?id=141437
Patch by Joseph Pecoraro <[email protected]> on 2015-02-10
Reviewed by Anders Carlsson.
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
API::Data::createWithoutCopying will automatically do the retaining / releasing for us.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (179873 => 179874)
--- trunk/Source/WebKit2/ChangeLog 2015-02-10 19:01:41 UTC (rev 179873)
+++ trunk/Source/WebKit2/ChangeLog 2015-02-10 19:11:44 UTC (rev 179874)
@@ -1,3 +1,14 @@
+2015-02-10 Joseph Pecoraro <[email protected]>
+
+ [Cocoa] NSData over retain in WKBrowsingContextController loadData
+ https://bugs.webkit.org/show_bug.cgi?id=141437
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
+ (-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
+ API::Data::createWithoutCopying will automatically do the retaining / releasing for us.
+
2015-02-10 Zhuo Li <[email protected]>
[WK2] Add support for registering url schemes to bypass Content Security Policy.
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm (179873 => 179874)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm 2015-02-10 19:01:41 UTC (rev 179873)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm 2015-02-10 19:11:44 UTC (rev 179874)
@@ -240,7 +240,6 @@
RefPtr<API::Data> apiData;
if (data) {
// FIXME: This should copy the data.
- [data retain];
apiData = API::Data::createWithoutCopying(data);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
