Title: [179896] trunk/Source/WebCore
- Revision
- 179896
- Author
- [email protected]
- Date
- 2015-02-10 16:00:53 -0800 (Tue, 10 Feb 2015)
Log Message
Stop using WebCore.exp.in on Mac and iOS.
https://bugs.webkit.org/show_bug.cgi?id=141413
Reviewed by Dan Bates.
* Configurations/Base.xcconfig:
Make symbols hidden by default unless exported by WEBCORE_EXPORT macros.
* platform/PlatformExportMacros.h:
Start using WEBCORE_EXPORT on Mac and iOS (but not Windows yet).
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (179895 => 179896)
--- trunk/Source/WebCore/ChangeLog 2015-02-10 23:59:09 UTC (rev 179895)
+++ trunk/Source/WebCore/ChangeLog 2015-02-11 00:00:53 UTC (rev 179896)
@@ -1,3 +1,15 @@
+2015-02-10 Alex Christensen <[email protected]>
+
+ Stop using WebCore.exp.in on Mac and iOS.
+ https://bugs.webkit.org/show_bug.cgi?id=141413
+
+ Reviewed by Dan Bates.
+
+ * Configurations/Base.xcconfig:
+ Make symbols hidden by default unless exported by WEBCORE_EXPORT macros.
+ * platform/PlatformExportMacros.h:
+ Start using WEBCORE_EXPORT on Mac and iOS (but not Windows yet).
+
2015-02-10 Chris Dumez <[email protected]>
Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange()
@@ -23,6 +35,18 @@
2015-02-10 Alex Christensen <[email protected]>
+ Stop using WebCore.exp.in on Mac and iOS.
+ https://bugs.webkit.org/show_bug.cgi?id=141413
+
+ Reviewed by Dan Bates.
+
+ * Configurations/Base.xcconfig:
+ Make symbols hidden by default unless exported by WEBCORE_EXPORT macros.
+ * platform/PlatformExportMacros.h:
+ Start using WEBCORE_EXPORT on Mac and iOS (but not Windows yet).
+
+2015-02-10 Alex Christensen <[email protected]>
+
Add more WEBCORE_EXPORT macros for iOS.
https://bugs.webkit.org/show_bug.cgi?id=141430
Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (179895 => 179896)
--- trunk/Source/WebCore/Configurations/Base.xcconfig 2015-02-10 23:59:09 UTC (rev 179895)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2015-02-11 00:00:53 UTC (rev 179896)
@@ -56,6 +56,7 @@
GCC_MODEL_TUNING[sdk=macosx*] = G5;
GCC_OBJC_CALL_CXX_CDTORS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
+GCC_SYMBOLS_PRIVATE_EXTERN = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
Modified: trunk/Source/WebCore/platform/PlatformExportMacros.h (179895 => 179896)
--- trunk/Source/WebCore/platform/PlatformExportMacros.h 2015-02-10 23:59:09 UTC (rev 179895)
+++ trunk/Source/WebCore/platform/PlatformExportMacros.h 2015-02-11 00:00:53 UTC (rev 179896)
@@ -32,41 +32,20 @@
#include <wtf/Platform.h>
#include <wtf/ExportMacros.h>
-#if defined(BUILDING_WebCore) || defined(BUILDING_WebKit) || \
- defined(STATICALLY_LINKED_WITH_WebCore) || defined(STATICALLY_LINKED_WITH_WebKit)
-#define WEBCORE_IS_LINKED_IN_SAME_BINARY 1
-#endif
-
// See note in wtf/Platform.h for more info on EXPORT_MACROS.
#if USE(EXPORT_MACROS)
-#if defined(WEBCORE_IS_LINKED_IN_SAME_BINARY)
-#define WEBKIT_EXPORTDATA WTF_EXPORT
+// FIXME: Get rid of WebKitExports.def.in and make this work on Windows.
+#if !PLATFORM(WIN)
+#define WEBCORE_EXPORT WTF_EXPORT
#else
-#define WEBKIT_EXPORTDATA WTF_IMPORT
+#define WEBCORE_EXPORT
#endif
-// FIXME: This should be WTF_EXPORT once WEBCORE_EXPORT is used instead of WebCore.exp.in.
-#define WEBCORE_EXPORT
-
#else // !USE(EXPORT_MACROS)
#define WEBCORE_EXPORT
-#if OS(WINDOWS) && !COMPILER(GCC)
-
-#if defined(WEBCORE_IS_LINKED_IN_SAME_BINARY)
-#define WEBKIT_EXPORTDATA __declspec(dllexport)
-#else
-#define WEBKIT_EXPORTDATA __declspec(dllimport)
-#endif
-
-#else // !PLATFORM...
-
-#define WEBKIT_EXPORTDATA
-
-#endif // !PLATFORM...
-
#endif // USE(EXPORT_MACROS)
#endif // PlatformExportMacros_h
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
