Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (180113 => 180114)
--- trunk/Source/_javascript_Core/ChangeLog 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-02-14 21:52:34 UTC (rev 180114)
@@ -1,3 +1,18 @@
+2015-02-14 David Kilzer <ddkil...@apple.com>
+
+ REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
+ <http://webkit.org/b/141607>
+
+ Work towards fixing the Mavericks Debug build.
+
+ * inspector/ScriptDebugServer.h:
+ (Inspector::ScriptDebugServer::Task): Export class.
+ * inspector/agents/InspectorDebuggerAgent.h:
+ (Inspector::InspectorDebuggerAgent::Listener): Export class.
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::setConsoleClient): Do not mark inline
+ method for export.
+
2015-02-14 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Symbol RemoteObject should not send sub-type
Modified: trunk/Source/_javascript_Core/inspector/ScriptDebugServer.h (180113 => 180114)
--- trunk/Source/_javascript_Core/inspector/ScriptDebugServer.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/_javascript_Core/inspector/ScriptDebugServer.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -60,7 +60,7 @@
const BreakpointActions& getActionsForBreakpoint(JSC::BreakpointID);
- class Task {
+ class JS_EXPORT_PRIVATE Task {
WTF_MAKE_FAST_ALLOCATED;
public:
virtual ~Task() { }
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h (180113 => 180114)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -96,7 +96,7 @@
void breakProgram(InspectorDebuggerFrontendDispatcher::Reason breakReason, RefPtr<InspectorObject>&& data);
void scriptExecutionBlockedByCSP(const String& directiveText);
- class Listener {
+ class JS_EXPORT_PRIVATE Listener {
public:
virtual ~Listener() { }
virtual void debuggerWasEnabled() = 0;
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.h (180113 => 180114)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -475,7 +475,7 @@
JSGlobalObjectDebuggable& inspectorDebuggable() { return *m_inspectorDebuggable.get(); }
#endif
- JS_EXPORT_PRIVATE void setConsoleClient(ConsoleClient* consoleClient) { m_consoleClient = consoleClient; }
+ void setConsoleClient(ConsoleClient* consoleClient) { m_consoleClient = consoleClient; }
ConsoleClient* consoleClient() const { return m_consoleClient; }
void setName(const String&);
Modified: trunk/Source/WebCore/ChangeLog (180113 => 180114)
--- trunk/Source/WebCore/ChangeLog 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/WebCore/ChangeLog 2015-02-14 21:52:34 UTC (rev 180114)
@@ -1,3 +1,24 @@
+2015-02-14 David Kilzer <ddkil...@apple.com>
+
+ REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
+ <http://webkit.org/b/141607>
+
+ Work towards fixing the Mavericks Debug build.
+
+ * dom/Document.h:
+ (WebCore::Document::setAnnotatedRegionsDirty):
+ * dom/Event.h:
+ (WebCore::Event::create):
+ * dom/Node.h:
+ (WebCore::Node::hasEditableStyle):
+ * dom/Position.h:
+ (WebCore::Position::Position):
+ * editing/FrameSelection.h:
+ (WebCore::DragCaretController::clear):
+ * loader/ResourceLoader.h:
+ (WebCore::ResourceLoader::originalRequest):
+ - Do not mark inline methods for export.
+
2015-02-14 Alexey Proskuryakov <a...@apple.com>
rel="noreferrer" should make window.opener null
Modified: trunk/Source/WebCore/dom/Document.h (180113 => 180114)
--- trunk/Source/WebCore/dom/Document.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/WebCore/dom/Document.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -1079,7 +1079,7 @@
bool frameElementsShouldIgnoreScrolling() const { return m_frameElementsShouldIgnoreScrolling; }
#if ENABLE(DASHBOARD_SUPPORT)
- WEBCORE_EXPORT void setAnnotatedRegionsDirty(bool f) { m_annotatedRegionsDirty = f; }
+ void setAnnotatedRegionsDirty(bool f) { m_annotatedRegionsDirty = f; }
bool annotatedRegionsDirty() const { return m_annotatedRegionsDirty; }
bool hasAnnotatedRegions () const { return m_hasAnnotatedRegions; }
void setHasAnnotatedRegions(bool f) { m_hasAnnotatedRegions = f; }
Modified: trunk/Source/WebCore/dom/Event.h (180113 => 180114)
--- trunk/Source/WebCore/dom/Event.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/WebCore/dom/Event.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -87,7 +87,7 @@
{
return adoptRef(*new Event);
}
- WEBCORE_EXPORT static Ref<Event> create(const AtomicString& type, bool canBubble, bool cancelable)
+ static Ref<Event> create(const AtomicString& type, bool canBubble, bool cancelable)
{
return adoptRef(*new Event(type, canBubble, cancelable));
}
Modified: trunk/Source/WebCore/dom/Node.h (180113 => 180114)
--- trunk/Source/WebCore/dom/Node.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/WebCore/dom/Node.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -363,7 +363,7 @@
WEBCORE_EXPORT void inspect();
- WEBCORE_EXPORT bool hasEditableStyle(EditableType editableType = ContentIsEditable, UserSelectAllTreatment treatment = UserSelectAllIsAlwaysNonEditable) const
+ bool hasEditableStyle(EditableType editableType = ContentIsEditable, UserSelectAllTreatment treatment = UserSelectAllIsAlwaysNonEditable) const
{
switch (editableType) {
case ContentIsEditable:
Modified: trunk/Source/WebCore/dom/Position.h (180113 => 180114)
--- trunk/Source/WebCore/dom/Position.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/WebCore/dom/Position.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -61,7 +61,7 @@
PositionIsAfterChildren,
};
- WEBCORE_EXPORT Position()
+ Position()
: m_offset(0)
, m_anchorType(PositionIsOffsetInAnchor)
, m_isLegacyEditingPosition(false)
Modified: trunk/Source/WebCore/editing/FrameSelection.h (180113 => 180114)
--- trunk/Source/WebCore/editing/FrameSelection.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/WebCore/editing/FrameSelection.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -102,7 +102,7 @@
bool hasCaret() const { return m_position.isNotNull(); }
const VisiblePosition& caretPosition() { return m_position; }
void setCaretPosition(const VisiblePosition&);
- WEBCORE_EXPORT void clear() { setCaretPosition(VisiblePosition()); }
+ void clear() { setCaretPosition(VisiblePosition()); }
void nodeWillBeRemoved(Node&);
Modified: trunk/Source/WebCore/loader/ResourceLoader.h (180113 => 180114)
--- trunk/Source/WebCore/loader/ResourceLoader.h 2015-02-14 20:41:18 UTC (rev 180113)
+++ trunk/Source/WebCore/loader/ResourceLoader.h 2015-02-14 21:52:34 UTC (rev 180114)
@@ -73,7 +73,7 @@
WEBCORE_EXPORT FrameLoader* frameLoader() const;
FrameLoader& dataProtocolFrameLoader() const;
DocumentLoader* documentLoader() const { return m_documentLoader.get(); }
- WEBCORE_EXPORT const ResourceRequest& originalRequest() const { return m_originalRequest; }
+ const ResourceRequest& originalRequest() const { return m_originalRequest; }
WEBCORE_EXPORT void cancel(const ResourceError&);
WEBCORE_EXPORT ResourceError cancelledError();
