Title: [180466] trunk/Websites/perf.webkit.org
- Revision
- 180466
- Author
- [email protected]
- Date
- 2015-02-20 16:35:18 -0800 (Fri, 20 Feb 2015)
Log Message
REGRESSION(r180333): Analysis tasks can't be associated with bugs
https://bugs.webkit.org/show_bug.cgi?id=141858
Reviewed by Andreas Kling.
Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
* public/v2/chart-pane.css:
* public/v2/index.html:
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (180465 => 180466)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-21 00:09:48 UTC (rev 180465)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-21 00:35:18 UTC (rev 180466)
@@ -1,5 +1,18 @@
2015-02-20 Ryosuke Niwa <[email protected]>
+ REGRESSION(r180333): Analysis tasks can't be associated with bugs
+ https://bugs.webkit.org/show_bug.cgi?id=141858
+
+ Reviewed by Andreas Kling.
+
+ Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
+ of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
+
+ * public/v2/chart-pane.css:
+ * public/v2/index.html:
+
+2015-02-20 Ryosuke Niwa <[email protected]>
+
Selecting revisions for A/B testing is hard
https://bugs.webkit.org/show_bug.cgi?id=141824
Modified: trunk/Websites/perf.webkit.org/public/v2/chart-pane.css (180465 => 180466)
--- trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-02-21 00:09:48 UTC (rev 180465)
+++ trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-02-21 00:35:18 UTC (rev 180466)
@@ -212,10 +212,6 @@
height: 15rem;
}
-.analysis-chart-pane .details {
- overflow: scroll;
-}
-
.analysis-chart-pane table {
margin: 0.5rem;
}
@@ -240,7 +236,7 @@
.chart-pane .details-table,
.chart-pane .commits-viewer {
font-size: 0.8rem;
- width: 100%;
+ width: auto;
table-layout: fixed;
border-collapse: collapse;
}
Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (180465 => 180466)
--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-21 00:09:48 UTC (rev 180465)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-21 00:35:18 UTC (rev 180466)
@@ -197,7 +197,9 @@
selection=overviewSelection}}
{{/if}}
</div>
- {{partial "chart-details"}}
+ <div class="details-table-container">
+ {{partial "chart-details"}}
+ </div>
</div>
</div>
@@ -247,7 +249,6 @@
<script type="text/x-handlebars" data-template-name="chart-details">
{{#if details}}
- <div class="details-table-container">
<table class="details-table">
<tbody class="bugs">
{{#each details.bugTrackers}}
@@ -311,7 +312,6 @@
{{commits-viewer repository=repository revisionInfo=this caption=name}}
{{/each}}
</div>
- </div>
{{/if}}
</script>
@@ -545,7 +545,23 @@
rangeRoute="analysisTask"}}
</div>
<div class="details">
- {{partial "chart-details"}}
+ <div class="details-table-container">
+ <table class="analysis-bugs">
+ <tbody>
+ {{#each bugTrackers}}
+ <tr>
+ <th>{{label}}</th>
+ <td>
+ <form {{action "associateBug" this editedBugNumber on="submit"}}>
+ {{input type=text value=editedBugNumber}}
+ </form>
+ </td>
+ </tr>
+ {{/each}}
+ </tbody>
+ </table>
+ {{partial "chart-details"}}
+ </div>
</div>
</section>
{{/if}}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
