Title: [180524] trunk/Tools
- Revision
- 180524
- Author
- [email protected]
- Date
- 2015-02-23 15:06:32 -0800 (Mon, 23 Feb 2015)
Log Message
Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
https://bugs.webkit.org/show_bug.cgi?id=141925
Reviewed by Tim Horton.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._presentPopoverForRevisionRange):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (180523 => 180524)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-02-23 23:04:53 UTC (rev 180523)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-02-23 23:06:32 UTC (rev 180524)
@@ -191,15 +191,19 @@
// FIXME: Nothing guarantees that Trac has historical data for these revisions.
var linesForCommits = this._popoverLinesForCommitRange(context.trac, context.branch, context.firstRevision, context.lastRevision);
- if (!linesForCommits.length)
- return false;
var line = document.createElement("div");
line.className = "title";
- line.textContent = "commits since previous result";
- content.appendChild(line);
- this._addDividerToPopover(content);
+ if (linesForCommits.length) {
+ line.textContent = "commits since previous result";
+ content.appendChild(line);
+ this._addDividerToPopover(content);
+ } else {
+ line.textContent = "no commits to " + context.branch + " since previous result";
+ content.appendChild(line);
+ }
+
for (var i = 0; i != linesForCommits.length; ++i)
content.appendChild(linesForCommits[i]);
Modified: trunk/Tools/ChangeLog (180523 => 180524)
--- trunk/Tools/ChangeLog 2015-02-23 23:04:53 UTC (rev 180523)
+++ trunk/Tools/ChangeLog 2015-02-23 23:06:32 UTC (rev 180524)
@@ -1,3 +1,13 @@
+2015-02-23 Alexey Proskuryakov <[email protected]>
+
+ Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
+ https://bugs.webkit.org/show_bug.cgi?id=141925
+
+ Reviewed by Tim Horton.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
+
2015-02-23 Anders Carlsson <[email protected]>
Add API for fetching website data records to _WKWebsiteDataStore
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
