Title: [180529] trunk/Source/_javascript_Core
- Revision
- 180529
- Author
- [email protected]
- Date
- 2015-02-23 15:50:01 -0800 (Mon, 23 Feb 2015)
Log Message
Get rid of JSLexicalEnvironment::argumentsGetter
https://bugs.webkit.org/show_bug.cgi?id=141930
Reviewed by Mark Lam.
This function is unused, and the way it's written is bizarre - it's a return statement that
dominates a bunch of dead code.
* runtime/JSLexicalEnvironment.cpp:
(JSC::JSLexicalEnvironment::argumentsGetter): Deleted.
* runtime/JSLexicalEnvironment.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (180528 => 180529)
--- trunk/Source/_javascript_Core/ChangeLog 2015-02-23 23:44:02 UTC (rev 180528)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-02-23 23:50:01 UTC (rev 180529)
@@ -1,5 +1,19 @@
2015-02-23 Filip Pizlo <[email protected]>
+ Get rid of JSLexicalEnvironment::argumentsGetter
+ https://bugs.webkit.org/show_bug.cgi?id=141930
+
+ Reviewed by Mark Lam.
+
+ This function is unused, and the way it's written is bizarre - it's a return statement that
+ dominates a bunch of dead code.
+
+ * runtime/JSLexicalEnvironment.cpp:
+ (JSC::JSLexicalEnvironment::argumentsGetter): Deleted.
+ * runtime/JSLexicalEnvironment.h:
+
+2015-02-23 Filip Pizlo <[email protected]>
+
Remove unused activationCount and allTheThingsCount variable declarations.
Rubber stamped by Mark Lam and Michael Saboff.
Modified: trunk/Source/_javascript_Core/runtime/JSLexicalEnvironment.cpp (180528 => 180529)
--- trunk/Source/_javascript_Core/runtime/JSLexicalEnvironment.cpp 2015-02-23 23:44:02 UTC (rev 180528)
+++ trunk/Source/_javascript_Core/runtime/JSLexicalEnvironment.cpp 2015-02-23 23:50:01 UTC (rev 180529)
@@ -197,23 +197,4 @@
return exec->globalThisValue();
}
-EncodedJSValue JSLexicalEnvironment::argumentsGetter(ExecState*, JSObject* slotBase, EncodedJSValue, PropertyName)
-{
- JSLexicalEnvironment* lexicalEnvironment = jsCast<JSLexicalEnvironment*>(slotBase);
- CallFrame* callFrame = CallFrame::create(reinterpret_cast<Register*>(lexicalEnvironment->m_registers));
- return JSValue::encode(jsUndefined());
-
- VirtualRegister argumentsRegister = callFrame->codeBlock()->argumentsRegister();
- if (JSValue arguments = callFrame->uncheckedR(argumentsRegister.offset()).jsValue())
- return JSValue::encode(arguments);
- int realArgumentsRegister = unmodifiedArgumentsRegister(argumentsRegister).offset();
-
- JSValue arguments = JSValue(Arguments::create(callFrame->vm(), callFrame, lexicalEnvironment));
- callFrame->uncheckedR(argumentsRegister.offset()) = arguments;
- callFrame->uncheckedR(realArgumentsRegister) = arguments;
-
- ASSERT(callFrame->uncheckedR(realArgumentsRegister).jsValue().inherits(Arguments::info()));
- return JSValue::encode(callFrame->uncheckedR(realArgumentsRegister).jsValue());
-}
-
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/JSLexicalEnvironment.h (180528 => 180529)
--- trunk/Source/_javascript_Core/runtime/JSLexicalEnvironment.h 2015-02-23 23:44:02 UTC (rev 180528)
+++ trunk/Source/_javascript_Core/runtime/JSLexicalEnvironment.h 2015-02-23 23:50:01 UTC (rev 180529)
@@ -97,8 +97,6 @@
bool symbolTablePut(ExecState*, PropertyName, JSValue, bool shouldThrow);
bool symbolTablePutWithAttributes(VM&, PropertyName, JSValue, unsigned attributes);
- static EncodedJSValue argumentsGetter(ExecState*, JSObject*, EncodedJSValue, PropertyName);
-
static size_t allocationSize(SymbolTable*);
static size_t storageOffset();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
