Title: [180534] trunk/Source/WebCore
- Revision
- 180534
- Author
- [email protected]
- Date
- 2015-02-23 16:55:53 -0800 (Mon, 23 Feb 2015)
Log Message
Log using diagnostic logging which ActiveDOMObjects prevent using the PageCache
https://bugs.webkit.org/show_bug.cgi?id=141922
<rdar://problem/19923085>
Reviewed by Andreas Kling.
Log using diagnostic logging which ActiveDOMObjects prevent using the
PageCache.
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
* page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::unsuspendableDOMObjectKey):
* page/DiagnosticLoggingKeys.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (180533 => 180534)
--- trunk/Source/WebCore/ChangeLog 2015-02-24 00:49:49 UTC (rev 180533)
+++ trunk/Source/WebCore/ChangeLog 2015-02-24 00:55:53 UTC (rev 180534)
@@ -1,5 +1,22 @@
2015-02-23 Chris Dumez <[email protected]>
+ Log using diagnostic logging which ActiveDOMObjects prevent using the PageCache
+ https://bugs.webkit.org/show_bug.cgi?id=141922
+ <rdar://problem/19923085>
+
+ Reviewed by Andreas Kling.
+
+ Log using diagnostic logging which ActiveDOMObjects prevent using the
+ PageCache.
+
+ * history/PageCache.cpp:
+ (WebCore::logCanCacheFrameDecision):
+ * page/DiagnosticLoggingKeys.cpp:
+ (WebCore::DiagnosticLoggingKeys::unsuspendableDOMObjectKey):
+ * page/DiagnosticLoggingKeys.h:
+
+2015-02-23 Chris Dumez <[email protected]>
+
Move GeoNotifier class to its own file
https://bugs.webkit.org/show_bug.cgi?id=141918
Modified: trunk/Source/WebCore/history/PageCache.cpp (180533 => 180534)
--- trunk/Source/WebCore/history/PageCache.cpp 2015-02-24 00:49:49 UTC (rev 180533)
+++ trunk/Source/WebCore/history/PageCache.cpp 2015-02-24 00:55:53 UTC (rev 180534)
@@ -184,6 +184,7 @@
PCLOG(" -The document cannot suspend its active DOM Objects");
for (auto* activeDOMObject : unsuspendableObjects) {
PCLOG(" - Unsuspendable: ", activeDOMObject->activeDOMObjectName());
+ diagnosticLoggingClient.logDiagnosticMessageWithValue(DiagnosticLoggingKeys::pageCacheKey(), DiagnosticLoggingKeys::unsuspendableDOMObjectKey(), activeDOMObject->activeDOMObjectName(), ShouldSample::Yes);
UNUSED_PARAM(activeDOMObject);
}
logPageCacheFailureDiagnosticMessage(diagnosticLoggingClient, DiagnosticLoggingKeys::cannotSuspendActiveDOMObjectsKey());
Modified: trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp (180533 => 180534)
--- trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp 2015-02-24 00:49:49 UTC (rev 180533)
+++ trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp 2015-02-24 00:55:53 UTC (rev 180534)
@@ -383,6 +383,11 @@
return ASCIILiteral("unsupportedHTTPMethod");
}
+String DiagnosticLoggingKeys::unsuspendableDOMObjectKey()
+{
+ return ASCIILiteral("unsuspendableDOMObject");
+}
+
String DiagnosticLoggingKeys::unusableCachedEntryKey()
{
return ASCIILiteral("unusableCachedEntry");
Modified: trunk/Source/WebCore/page/DiagnosticLoggingKeys.h (180533 => 180534)
--- trunk/Source/WebCore/page/DiagnosticLoggingKeys.h 2015-02-24 00:49:49 UTC (rev 180533)
+++ trunk/Source/WebCore/page/DiagnosticLoggingKeys.h 2015-02-24 00:55:53 UTC (rev 180534)
@@ -108,6 +108,7 @@
static String svgDocumentKey();
WEBCORE_EXPORT static String uncacheableStatusCodeKey();
WEBCORE_EXPORT static String unsupportedHTTPMethodKey();
+ static String unsuspendableDOMObjectKey();
WEBCORE_EXPORT static String unusableCachedEntryKey();
WEBCORE_EXPORT static String unusedKey();
static String unusedReasonCredentialSettingsKey();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
