Title: [180668] trunk/Source/WTF
- Revision
- 180668
- Author
- [email protected]
- Date
- 2015-02-26 02:50:57 -0800 (Thu, 26 Feb 2015)
Log Message
UNREACHABLE_FOR_PLATFORM() should be release assert
https://bugs.webkit.org/show_bug.cgi?id=141904
Reviewed by Darin Adler.
* wtf/Assertions.h:
(UNREACHABLE_FOR_PLATFORM):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (180667 => 180668)
--- trunk/Source/WTF/ChangeLog 2015-02-26 09:20:24 UTC (rev 180667)
+++ trunk/Source/WTF/ChangeLog 2015-02-26 10:50:57 UTC (rev 180668)
@@ -1,3 +1,13 @@
+2015-02-26 Csaba Osztrogonác <[email protected]>
+
+ UNREACHABLE_FOR_PLATFORM() should be release assert
+ https://bugs.webkit.org/show_bug.cgi?id=141904
+
+ Reviewed by Darin Adler.
+
+ * wtf/Assertions.h:
+ (UNREACHABLE_FOR_PLATFORM):
+
2015-02-25 Filip Pizlo <[email protected]>
Enable concurrent JIT on GTK
Modified: trunk/Source/WTF/wtf/Assertions.h (180667 => 180668)
--- trunk/Source/WTF/wtf/Assertions.h 2015-02-26 09:20:24 UTC (rev 180667)
+++ trunk/Source/WTF/wtf/Assertions.h 2015-02-26 10:50:57 UTC (rev 180668)
@@ -356,6 +356,18 @@
#define LOG_VERBOSE(channel, ...) WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, &JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
#endif
+/* RELEASE_ASSERT */
+
+#if ASSERT_DISABLED
+#define RELEASE_ASSERT(assertion) (UNLIKELY(!(assertion)) ? (CRASH()) : (void)0)
+#define RELEASE_ASSERT_WITH_MESSAGE(assertion, ...) RELEASE_ASSERT(assertion)
+#define RELEASE_ASSERT_NOT_REACHED() CRASH()
+#else
+#define RELEASE_ASSERT(assertion) ASSERT(assertion)
+#define RELEASE_ASSERT_WITH_MESSAGE(assertion, ...) ASSERT_WITH_MESSAGE(assertion, __VA_ARGS__)
+#define RELEASE_ASSERT_NOT_REACHED() ASSERT_NOT_REACHED()
+#endif
+
/* UNREACHABLE_FOR_PLATFORM */
#if COMPILER(CLANG)
@@ -365,21 +377,12 @@
#pragma clang diagnostic ignored "-Wmissing-noreturn"
static inline void UNREACHABLE_FOR_PLATFORM()
{
- CRASH();
+ RELEASE_ASSERT_NOT_REACHED();
}
#pragma clang diagnostic pop
#else
-#define UNREACHABLE_FOR_PLATFORM() ASSERT_NOT_REACHED()
+#define UNREACHABLE_FOR_PLATFORM() RELEASE_ASSERT_NOT_REACHED()
#endif
-#if ASSERT_DISABLED
-#define RELEASE_ASSERT(assertion) (UNLIKELY(!(assertion)) ? (CRASH()) : (void)0)
-#define RELEASE_ASSERT_WITH_MESSAGE(assertion, ...) RELEASE_ASSERT(assertion)
-#define RELEASE_ASSERT_NOT_REACHED() CRASH()
-#else
-#define RELEASE_ASSERT(assertion) ASSERT(assertion)
-#define RELEASE_ASSERT_WITH_MESSAGE(assertion, ...) ASSERT_WITH_MESSAGE(assertion, __VA_ARGS__)
-#define RELEASE_ASSERT_NOT_REACHED() ASSERT_NOT_REACHED()
-#endif
#endif /* WTF_Assertions_h */
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
