Title: [181067] trunk/Source/WebCore
- Revision
- 181067
- Author
- [email protected]
- Date
- 2015-03-04 21:14:53 -0800 (Wed, 04 Mar 2015)
Log Message
Switch new soft-linking debug asserts to release asserts
<http://webkit.org/b/142176>
Reviewed by Alex Christensen.
* platform/mac/SoftLinking.h:
(SOFT_LINK_CONSTANT_SOURCE): Switch to release assert.
(SOFT_LINK_FUNCTION_SOURCE): Ditto.
* platform/win/SoftLinking.h:
(SOFT_LINK_CONSTANT_SOURCE): Ditto.
(SOFT_LINK_FUNCTION_SOURCE): Ditto. Note that this method is
effectively only called once because the function pointer is
replaced after the first time it's called.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (181066 => 181067)
--- trunk/Source/WebCore/ChangeLog 2015-03-05 05:13:46 UTC (rev 181066)
+++ trunk/Source/WebCore/ChangeLog 2015-03-05 05:14:53 UTC (rev 181067)
@@ -1,3 +1,19 @@
+2015-03-04 David Kilzer <[email protected]>
+
+ Switch new soft-linking debug asserts to release asserts
+ <http://webkit.org/b/142176>
+
+ Reviewed by Alex Christensen.
+
+ * platform/mac/SoftLinking.h:
+ (SOFT_LINK_CONSTANT_SOURCE): Switch to release assert.
+ (SOFT_LINK_FUNCTION_SOURCE): Ditto.
+ * platform/win/SoftLinking.h:
+ (SOFT_LINK_CONSTANT_SOURCE): Ditto.
+ (SOFT_LINK_FUNCTION_SOURCE): Ditto. Note that this method is
+ effectively only called once because the function pointer is
+ replaced after the first time it's called.
+
2015-03-04 Alex Christensen <[email protected]>
Optimize content extensions.
Modified: trunk/Source/WebCore/platform/mac/SoftLinking.h (181066 => 181067)
--- trunk/Source/WebCore/platform/mac/SoftLinking.h 2015-03-05 05:13:46 UTC (rev 181066)
+++ trunk/Source/WebCore/platform/mac/SoftLinking.h 2015-03-05 05:14:53 UTC (rev 181067)
@@ -337,7 +337,7 @@
static dispatch_once_t once; \
dispatch_once(&once, ^{ \
void* constant = dlsym(framework##Library(), #variableName); \
- ASSERT_WITH_MESSAGE(constant, "%s", dlerror()); \
+ RELEASE_ASSERT_WITH_MESSAGE(constant, "%s", dlerror()); \
constant##framework##variableName = *static_cast<variableType*>(constant); \
}); \
return constant##framework##variableName; \
@@ -368,7 +368,7 @@
static dispatch_once_t once; \
dispatch_once(&once, ^{ \
softLink##framework##functionName = (resultType (*) parameterDeclarations) dlsym(framework##Library(), #functionName); \
- ASSERT_WITH_MESSAGE(softLink##framework##functionName, "%s", dlerror()); \
+ RELEASE_ASSERT_WITH_MESSAGE(softLink##framework##functionName, "%s", dlerror()); \
}); \
return softLink##framework##functionName parameterNames; \
} \
Modified: trunk/Source/WebCore/platform/win/SoftLinking.h (181066 => 181067)
--- trunk/Source/WebCore/platform/win/SoftLinking.h 2015-03-05 05:13:46 UTC (rev 181066)
+++ trunk/Source/WebCore/platform/win/SoftLinking.h 2015-03-05 05:14:53 UTC (rev 181067)
@@ -213,7 +213,7 @@
namespace functionNamespace { \
static void init##framework##variableName(void* context) { \
variableType* ptr = reinterpret_cast<variableType*>(SOFT_LINK_GETPROCADDRESS(framework##Library(), #variableName)); \
- ASSERT(ptr); \
+ RELEASE_ASSERT(ptr); \
*static_cast<variableType*>(context) = *ptr; \
} \
variableType get_##framework##_##variableName(); \
@@ -242,7 +242,7 @@
static resultType __cdecl init##framework##functionName parameterDeclarations \
{ \
softLink##framework##functionName = reinterpret_cast<resultType (__cdecl*)parameterDeclarations>(SOFT_LINK_GETPROCADDRESS(framework##Library(), #functionName)); \
- ASSERT(softLink##framework##functionName); \
+ RELEASE_ASSERT(softLink##framework##functionName); \
return softLink##framework##functionName parameterNames; \
} \
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
