Title: [181469] trunk/Source/_javascript_Core
- Revision
- 181469
- Author
- [email protected]
- Date
- 2015-03-12 20:02:16 -0700 (Thu, 12 Mar 2015)
Log Message
Change the DFG crashLock to use std::atomic.
<https://webkit.org/b/142649>
Reviewed by Filip Pizlo.
* dfg/DFGCommon.cpp:
(JSC::DFG::startCrashing):
(JSC::DFG::isCrashing):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (181468 => 181469)
--- trunk/Source/_javascript_Core/ChangeLog 2015-03-13 02:01:42 UTC (rev 181468)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-03-13 03:02:16 UTC (rev 181469)
@@ -1,3 +1,14 @@
+2015-03-12 Mark Lam <[email protected]>
+
+ Change the DFG crashLock to use std::atomic.
+ <https://webkit.org/b/142649>
+
+ Reviewed by Filip Pizlo.
+
+ * dfg/DFGCommon.cpp:
+ (JSC::DFG::startCrashing):
+ (JSC::DFG::isCrashing):
+
2015-03-12 Filip Pizlo <[email protected]>
Bytecode liveness analysis should have more lambdas and fewer sets
Modified: trunk/Source/_javascript_Core/dfg/DFGCommon.cpp (181468 => 181469)
--- trunk/Source/_javascript_Core/dfg/DFGCommon.cpp 2015-03-13 02:01:42 UTC (rev 181468)
+++ trunk/Source/_javascript_Core/dfg/DFGCommon.cpp 2015-03-13 03:02:16 UTC (rev 181469)
@@ -34,21 +34,20 @@
namespace JSC { namespace DFG {
-static unsigned crashLock;
+static std::atomic<unsigned> crashLock;
void startCrashing()
{
-#if ENABLE(COMPARE_AND_SWAP)
- while (!WTF::weakCompareAndSwap(&crashLock, 0, 1))
+ unsigned expected = 0;
+ while (!crashLock.compare_exchange_weak(expected, 1, std::memory_order_acquire)) {
std::this_thread::yield();
-#else
- crashLock = 1;
-#endif
+ expected = 0;
+ }
}
bool isCrashing()
{
- return !!crashLock;
+ return !!crashLock.load(std::memory_order_acquire);
}
} } // namespace JSC::DFG
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
