Title: [181513] trunk/Source/WebCore
- Revision
- 181513
- Author
- [email protected]
- Date
- 2015-03-15 13:42:44 -0700 (Sun, 15 Mar 2015)
Log Message
Remove a redundant repaint when a layer becomes composited
https://bugs.webkit.org/show_bug.cgi?id=142711
Reviewed by Anders Carlsson.
RenderLayerCompositor::computeCompositingRequirements() doesn't need to call
repaintOnCompositingChange() when a layer is going to become composited,
because updateBacking() does exactly the same thing. I used an assertion
and ran the tests to ensure this wasn't a behavior change.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (181512 => 181513)
--- trunk/Source/WebCore/ChangeLog 2015-03-15 19:43:18 UTC (rev 181512)
+++ trunk/Source/WebCore/ChangeLog 2015-03-15 20:42:44 UTC (rev 181513)
@@ -1,3 +1,18 @@
+2015-03-15 Simon Fraser <[email protected]>
+
+ Remove a redundant repaint when a layer becomes composited
+ https://bugs.webkit.org/show_bug.cgi?id=142711
+
+ Reviewed by Anders Carlsson.
+
+ RenderLayerCompositor::computeCompositingRequirements() doesn't need to call
+ repaintOnCompositingChange() when a layer is going to become composited,
+ because updateBacking() does exactly the same thing. I used an assertion
+ and ran the tests to ensure this wasn't a behavior change.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+
2015-03-15 Benjamin Poulain <[email protected]>
Change the exact attribute matching to be ASCII case-insensitive
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (181512 => 181513)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2015-03-15 19:43:18 UTC (rev 181512)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2015-03-15 20:42:44 UTC (rev 181513)
@@ -1447,10 +1447,7 @@
#endif
}
- // If the layer is going into compositing mode, repaint its old location.
ASSERT(willBeComposited == needsToBeComposited(layer));
- if (!layer.isComposited() && willBeComposited)
- repaintOnCompositingChange(layer);
// Update backing now, so that we can use isComposited() reliably during tree traversal in rebuildCompositingLayerTree().
if (updateBacking(layer, CompositingChangeRepaintNow, willBeComposited ? BackingRequired::Yes : BackingRequired::No))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
