Title: [181546] releases/WebKitGTK/webkit-2.8/Source/WebCore
- Revision
- 181546
- Author
- [email protected]
- Date
- 2015-03-16 04:48:33 -0700 (Mon, 16 Mar 2015)
Log Message
Merge r181475 - Fix Debug build error 'comparison is always true due to limited range of data type [-Werror=type-limits]'
https://bugs.webkit.org/show_bug.cgi?id=142652
Patch by Joonghun Park <[email protected]> on 2015-03-13
Reviewed by Csaba Osztrogonác.
No new tests, no behavior changes.
Now CSSPropertyID type is uint16_t, so propertyID >= 0 check is needed no more.
* css/CSSPrimitiveValue.cpp:
(WebCore::propertyName):
* css/makeprop.pl:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (181545 => 181546)
--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-16 11:47:11 UTC (rev 181545)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-16 11:48:33 UTC (rev 181546)
@@ -1,3 +1,18 @@
+2015-03-13 Joonghun Park <[email protected]>
+
+ Fix Debug build error 'comparison is always true due to limited range of data type [-Werror=type-limits]'
+ https://bugs.webkit.org/show_bug.cgi?id=142652
+
+ Reviewed by Csaba Osztrogonác.
+
+ No new tests, no behavior changes.
+
+ Now CSSPropertyID type is uint16_t, so propertyID >= 0 check is needed no more.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::propertyName):
+ * css/makeprop.pl:
+
2015-03-12 Sebastian Dröge <[email protected]>
Stop using single-include headers that are only available since GStreamer >= 1.2.
Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/css/CSSPrimitiveValue.cpp (181545 => 181546)
--- releases/WebKitGTK/webkit-2.8/Source/WebCore/css/CSSPrimitiveValue.cpp 2015-03-16 11:47:11 UTC (rev 181545)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/css/CSSPrimitiveValue.cpp 2015-03-16 11:48:33 UTC (rev 181546)
@@ -217,7 +217,6 @@
static const AtomicString& propertyName(CSSPropertyID propertyID)
{
- ASSERT_ARG(propertyID, propertyID >= 0);
ASSERT_ARG(propertyID, (propertyID >= firstCSSProperty && propertyID < firstCSSProperty + numCSSProperties));
return getPropertyNameAtomicString(propertyID);
Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/css/makeprop.pl (181545 => 181546)
--- releases/WebKitGTK/webkit-2.8/Source/WebCore/css/makeprop.pl 2015-03-16 11:47:11 UTC (rev 181545)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/css/makeprop.pl 2015-03-16 11:48:33 UTC (rev 181546)
@@ -249,7 +249,7 @@
bool CSSProperty::isInheritedProperty(CSSPropertyID id)
{
- ASSERT(id >= 0 && id <= lastCSSProperty);
+ ASSERT(id <= lastCSSProperty);
ASSERT(id != CSSPropertyInvalid);
return isInheritedPropertyTable[id];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
