Title: [181552] releases/WebKitGTK/webkit-2.8/Source/WebCore
Revision
181552
Author
[email protected]
Date
2015-03-16 05:30:43 -0700 (Mon, 16 Mar 2015)

Log Message

Merge r181513 - Remove a redundant repaint when a layer becomes composited
https://bugs.webkit.org/show_bug.cgi?id=142711

Reviewed by Anders Carlsson.

RenderLayerCompositor::computeCompositingRequirements() doesn't need to call
repaintOnCompositingChange() when a layer is going to become composited,
because updateBacking() does exactly the same thing. I used an assertion
and ran the tests to ensure this wasn't a behavior change.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (181551 => 181552)


--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-03-16 12:28:55 UTC (rev 181551)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-03-16 12:30:43 UTC (rev 181552)
@@ -1,3 +1,18 @@
+2015-03-15  Simon Fraser  <[email protected]>
+
+        Remove a redundant repaint when a layer becomes composited
+        https://bugs.webkit.org/show_bug.cgi?id=142711
+
+        Reviewed by Anders Carlsson.
+
+        RenderLayerCompositor::computeCompositingRequirements() doesn't need to call
+        repaintOnCompositingChange() when a layer is going to become composited,
+        because updateBacking() does exactly the same thing. I used an assertion
+        and ran the tests to ensure this wasn't a behavior change.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+
 2015-03-14  Adenilson Cavalcanti  <[email protected]>
 
         RenderBlock::imageChange() calling const methods on exit

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderLayerCompositor.cpp (181551 => 181552)


--- releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderLayerCompositor.cpp	2015-03-16 12:28:55 UTC (rev 181551)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderLayerCompositor.cpp	2015-03-16 12:30:43 UTC (rev 181552)
@@ -1411,10 +1411,7 @@
 #endif
     }
     
-    // If the layer is going into compositing mode, repaint its old location.
     ASSERT(willBeComposited == needsToBeComposited(layer));
-    if (!layer.isComposited() && willBeComposited)
-        repaintOnCompositingChange(layer);
 
     // Update backing now, so that we can use isComposited() reliably during tree traversal in rebuildCompositingLayerTree().
     if (updateBacking(layer, CompositingChangeRepaintNow))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to