Diff
Modified: trunk/Source/WebCore/ChangeLog (181618 => 181619)
--- trunk/Source/WebCore/ChangeLog 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/ChangeLog 2015-03-17 07:15:26 UTC (rev 181619)
@@ -1,3 +1,15 @@
+2015-03-17 Joseph Pecoraro <[email protected]>
+
+ Remove never used "useLayerOnTop" bindings generator argument
+ https://bugs.webkit.org/show_bug.cgi?id=142773
+
+ Reviewed by Darin Adler.
+
+ * bindings/scripts/CodeGenerator.pm:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * bindings/scripts/generate-bindings.pl:
+
2015-03-16 Ryosuke Niwa <[email protected]>
Enable ES6 classes by default
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (181618 => 181619)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2015-03-17 07:15:26 UTC (rev 181619)
@@ -35,7 +35,6 @@
my $useOutputDir = "";
my $useOutputHeadersDir = "";
my $useDirectories = "";
-my $useLayerOnTop = 0;
my $preprocessor;
my $writeDependencies = 0;
my $defines = "";
@@ -110,7 +109,6 @@
$useGenerator = shift;
$useOutputDir = shift;
$useOutputHeadersDir = shift;
- $useLayerOnTop = shift;
$preprocessor = shift;
$writeDependencies = shift;
$verbose = shift;
@@ -132,7 +130,7 @@
%enumTypeHash = map { $_->name => $_->values } @{$useDocument->enumerations};
# Dynamically load external code generation perl module
- $codeGenerator = $ifaceName->new($object, $useLayerOnTop, $preprocessor, $writeDependencies, $verbose, $targetIdlFilePath);
+ $codeGenerator = $ifaceName->new($object, $preprocessor, $writeDependencies, $verbose, $targetIdlFilePath);
unless (defined($codeGenerator)) {
my $interfaces = $useDocument->interfaces;
foreach my $interface (@$interfaces) {
@@ -157,7 +155,7 @@
require $ifaceName . ".pm";
# Dynamically load external code generation perl module
- $codeGenerator = $ifaceName->new($object, $useLayerOnTop, $preprocessor, $writeDependencies, $verbose);
+ $codeGenerator = $ifaceName->new($object, $preprocessor, $writeDependencies, $verbose);
return $codeGenerator->FileNamePrefix();
}
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (181618 => 181619)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-03-17 07:15:26 UTC (rev 181619)
@@ -36,8 +36,6 @@
my $codeGenerator;
-my $writeDependencies = 0;
-
my @headerContentHeader = ();
my @headerContent = ();
my %headerIncludes = ();
@@ -114,9 +112,6 @@
my $reference = { };
$codeGenerator = shift;
- shift; # $useLayerOnTop
- shift; # $preprocessor
- $writeDependencies = shift;
bless($reference, $object);
return $reference;
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (181618 => 181619)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2015-03-17 07:15:26 UTC (rev 181619)
@@ -224,7 +224,6 @@
my $reference = { };
$codeGenerator = shift;
- shift; # $useLayerOnTop
shift; # $preprocessor
$writeDependencies = shift;
Modified: trunk/Source/WebCore/bindings/scripts/generate-bindings.pl (181618 => 181619)
--- trunk/Source/WebCore/bindings/scripts/generate-bindings.pl 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/bindings/scripts/generate-bindings.pl 2015-03-17 07:15:26 UTC (rev 181619)
@@ -114,7 +114,7 @@
}
if (!$idlFound) {
- my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, 0, $preprocessor, $writeDependencies, $verbose);
+ my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, $preprocessor, $writeDependencies, $verbose);
# We generate empty .h and .cpp files just to tell build scripts that .h and .cpp files are created.
generateEmptyHeaderAndCpp($codeGen->FileNamePrefix(), $targetInterfaceName, $outputHeadersDirectory, $outputDirectory);
@@ -191,7 +191,7 @@
}
# Generate desired output for the target IDL file.
-my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, 0, $preprocessor, $writeDependencies, $verbose, $targetIdlFile);
+my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, $preprocessor, $writeDependencies, $verbose, $targetIdlFile);
$codeGen->ProcessDocument($targetDocument, $defines);
sub generateEmptyHeaderAndCpp
Modified: trunk/Tools/ChangeLog (181618 => 181619)
--- trunk/Tools/ChangeLog 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Tools/ChangeLog 2015-03-17 07:15:26 UTC (rev 181619)
@@ -1,3 +1,13 @@
+2015-03-17 Joseph Pecoraro <[email protected]>
+
+ Remove never used "useLayerOnTop" bindings generator argument
+ https://bugs.webkit.org/show_bug.cgi?id=142773
+
+ Reviewed by Darin Adler.
+
+ * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
+ (new):
+
2015-03-16 Ryosuke Niwa <[email protected]>
Enable ES6 classes by default
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm (181618 => 181619)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm 2015-03-17 07:15:26 UTC (rev 181619)
@@ -30,7 +30,7 @@
sub new
{
- my ($class, $codeGenerator, $layerOnTop, $preprocessor, $writeDependencies, $verbose, $idlFilePath) = @_;
+ my ($class, $codeGenerator, $preprocessor, $writeDependencies, $verbose, $idlFilePath) = @_;
my $reference = {
codeGenerator => $codeGenerator,
