Title: [181634] releases/WebKitGTK/webkit-2.8/Source/WebCore
- Revision
- 181634
- Author
- [email protected]
- Date
- 2015-03-17 04:43:12 -0700 (Tue, 17 Mar 2015)
Log Message
Merge r181565 - URLs visited during private browsing show up in WebpageIcons.db
rdar://problem/11254910 and https://bugs.webkit.org/show_bug.cgi?id=142733
Patch by Sam Weinig. Reviewed by Brady Eidson.
* loader/icon/IconController.cpp:
(WebCore::IconController::startLoader): Bail early here if the page is using an ephemeral session.
(WebCore::IconController::continueLoadWithDecision): Instead of here.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (181633 => 181634)
--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-17 11:38:56 UTC (rev 181633)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-17 11:43:12 UTC (rev 181634)
@@ -1,3 +1,24 @@
+2015-03-16 Brady Eidson <[email protected]>
+
+ Addressing additional review feedback after http://trac.webkit.org/changeset/181565
+ https://bugs.webkit.org/show_bug.cgi?id=142604
+
+ Reviewed by Darin Adler.
+
+ * loader/icon/IconController.cpp:
+ (WebCore::IconController::startLoader): Null check page()
+
+2015-03-16 Brady Eidson <[email protected]>
+
+ URLs visited during private browsing show up in WebpageIcons.db
+ rdar://problem/11254910 and https://bugs.webkit.org/show_bug.cgi?id=142733
+
+ Patch by Sam Weinig. Reviewed by Brady Eidson.
+
+ * loader/icon/IconController.cpp:
+ (WebCore::IconController::startLoader): Bail early here if the page is using an ephemeral session.
+ (WebCore::IconController::continueLoadWithDecision): Instead of here.
+
2015-03-16 Max Stepin <[email protected]>
Add APNG support
Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/icon/IconController.cpp (181633 => 181634)
--- releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/icon/IconController.cpp 2015-03-17 11:38:56 UTC (rev 181633)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/icon/IconController.cpp 2015-03-17 11:43:12 UTC (rev 181634)
@@ -160,6 +160,10 @@
}
if (iconDatabase().supportsAsynchronousMode()) {
+ // FIXME (<rdar://problem/9168605>) - We should support in-memory-only private browsing icons in asynchronous icon database mode.
+ if (m_frame.page() && m_frame.page()->usesEphemeralSession())
+ return;
+
m_frame.loader().documentLoader()->getIconLoadDecisionForIconURL(urlString);
// Commit the icon url mapping to the database just in case we don't end up loading later.
commitToDatabase(iconURL);
@@ -203,10 +207,6 @@
{
ASSERT(iconLoadDecision != IconLoadUnknown);
- // FIXME (<rdar://problem/9168605>) - We should support in-memory-only private browsing icons in asynchronous icon database mode.
- if (iconDatabase().supportsAsynchronousMode() && m_frame.page()->usesEphemeralSession())
- return;
-
if (iconLoadDecision == IconLoadNo) {
URL iconURL(url());
String urlString(iconURL.string());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
