Title: [181649] trunk/Source/WebCore
- Revision
- 181649
- Author
- [email protected]
- Date
- 2015-03-17 08:48:32 -0700 (Tue, 17 Mar 2015)
Log Message
'pageLoaded' diagnostic logging is too verbose
https://bugs.webkit.org/show_bug.cgi?id=142727
<rdar://problem/18937048>
Reviewed by Eric Carlson.
Make 'pageLoaded' diagnostic logging less verbose:
- Log once per main frame instead of once for subframe
- Apply sampling
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (181648 => 181649)
--- trunk/Source/WebCore/ChangeLog 2015-03-17 13:37:55 UTC (rev 181648)
+++ trunk/Source/WebCore/ChangeLog 2015-03-17 15:48:32 UTC (rev 181649)
@@ -1,3 +1,18 @@
+2015-03-17 Chris Dumez <[email protected]>
+
+ 'pageLoaded' diagnostic logging is too verbose
+ https://bugs.webkit.org/show_bug.cgi?id=142727
+ <rdar://problem/18937048>
+
+ Reviewed by Eric Carlson.
+
+ Make 'pageLoaded' diagnostic logging less verbose:
+ - Log once per main frame instead of once for subframe
+ - Apply sampling
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
+
2015-03-17 Carlos Garcia Campos <[email protected]>
[GTK] Wrong transfer annotations used in GObject DOM bindings
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (181648 => 181649)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2015-03-17 13:37:55 UTC (rev 181648)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2015-03-17 15:48:32 UTC (rev 181649)
@@ -2269,8 +2269,8 @@
if (AXObjectCache* cache = m_frame.document()->existingAXObjectCache())
cache->frameLoadingEventNotification(&m_frame, loadingEvent);
- if (page)
- page->mainFrame().diagnosticLoggingClient().logDiagnosticMessageWithResult(DiagnosticLoggingKeys::pageLoadedKey(), emptyString(), error.isNull() ? DiagnosticLoggingResultPass : DiagnosticLoggingResultFail, ShouldSample::No);
+ if (page && m_frame.isMainFrame())
+ page->mainFrame().diagnosticLoggingClient().logDiagnosticMessageWithResult(DiagnosticLoggingKeys::pageLoadedKey(), emptyString(), error.isNull() ? DiagnosticLoggingResultPass : DiagnosticLoggingResultFail, ShouldSample::Yes);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
