Title: [181662] trunk/Source/WebCore
Revision
181662
Author
[email protected]
Date
2015-03-17 13:28:33 -0700 (Tue, 17 Mar 2015)

Log Message

REGRESSION (r181423): Crash @ generatedcontent.org at com.apple.WebCore: WebCore::MediaPlayer::maximumDurationToCacheMediaTime const + 4
https://bugs.webkit.org/show_bug.cgi?id=142787

Reviewed by Eric Carlson.

Null check m_player before derefencing.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (181661 => 181662)


--- trunk/Source/WebCore/ChangeLog	2015-03-17 20:22:36 UTC (rev 181661)
+++ trunk/Source/WebCore/ChangeLog	2015-03-17 20:28:33 UTC (rev 181662)
@@ -1,3 +1,15 @@
+2015-03-17  Jer Noble  <[email protected]>
+
+        REGRESSION (r181423): Crash @ generatedcontent.org at com.apple.WebCore: WebCore::MediaPlayer::maximumDurationToCacheMediaTime const + 4
+        https://bugs.webkit.org/show_bug.cgi?id=142787
+
+        Reviewed by Eric Carlson.
+
+        Null check m_player before derefencing.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::parseAttribute):
+
 2015-03-17  Beth Dakin  <[email protected]>
 
         DOM mouse events have weird timing for force clickable elements in Safari 8.0.3 on 

Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (181661 => 181662)


--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2015-03-17 20:22:36 UTC (rev 181661)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2015-03-17 20:28:33 UTC (rev 181662)
@@ -2474,7 +2474,7 @@
 
 void HTMLMediaElement::invalidateCachedTime() const
 {
-    if (!m_player->maximumDurationToCacheMediaTime())
+    if (!m_player || !m_player->maximumDurationToCacheMediaTime())
         return;
 
 #if !LOG_DISABLED
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to