Title: [181666] trunk/Source/WebCore
- Revision
- 181666
- Author
- [email protected]
- Date
- 2015-03-17 15:12:46 -0700 (Tue, 17 Mar 2015)
Log Message
When tab hides, pause fullscreen and exit normally.
https://bugs.webkit.org/show_bug.cgi?id=142685
Patch by Jeremy Jones <[email protected]> on 2015-03-17
Reviewed by Eric Carlson.
Pause fullscreen playback when switching tabs. Exit fullscreen is not necessary and even prevents
the normal flow of teardown. This allows the normal exit fullscreen call to succeed and call its callback.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (181665 => 181666)
--- trunk/Source/WebCore/ChangeLog 2015-03-17 21:29:21 UTC (rev 181665)
+++ trunk/Source/WebCore/ChangeLog 2015-03-17 22:12:46 UTC (rev 181666)
@@ -1,3 +1,16 @@
+2015-03-17 Jeremy Jones <[email protected]>
+
+ When tab hides, pause fullscreen and exit normally.
+ https://bugs.webkit.org/show_bug.cgi?id=142685
+
+ Reviewed by Eric Carlson.
+
+ Pause fullscreen playback when switching tabs. Exit fullscreen is not necessary and even prevents
+ the normal flow of teardown. This allows the normal exit fullscreen call to succeed and call its callback.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):
+
2015-03-17 Per Arne Vollan <[email protected]>
[WinCairo] Video position is incorrect when located inside a frame.
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (181665 => 181666)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-03-17 21:29:21 UTC (rev 181665)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-03-17 22:12:46 UTC (rev 181666)
@@ -1154,12 +1154,12 @@
RefPtr<WebVideoFullscreenInterfaceAVKit> strongThis(this);
dispatch_async(dispatch_get_main_queue(), [strongThis] {
[strongThis->m_window setHidden:YES];
- [strongThis->m_playerViewController exitFullScreenAnimated:NO completionHandler:[strongThis] (BOOL, NSError*) {
- }];
});
- if (m_videoFullscreenModel && !m_exitRequested)
+ if (m_videoFullscreenModel && !m_exitRequested) {
+ m_videoFullscreenModel->pause();
m_videoFullscreenModel->requestExitFullscreen();
+ }
}
void WebVideoFullscreenInterfaceAVKit::preparedToReturnToInline(bool visible, const IntRect& inlineRect)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
