[webkit-changes] [181761] trunk/Websites/perf.webkit.org

Thu, 19 Mar 2015 15:37:19 -0700

Title: [181761] trunk/Websites/perf.webkit.org
Revision
181761
Author
[email protected]
Date
2015-03-19 15:36:43 -0700 (Thu, 19 Mar 2015)

Log Message

Unreviewed build fixes.

* public/include/manifest.php:
(Manifest::generate): These should be {} instead of [] when they're empty.
* public/v2/data.js:
(Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
* public/v2/manifest.js:
(App.Metric.fullName): Fixed the typo.
* tests/admin-regenerate-manifest.js: Fixed the test.


Modified Paths

Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (181760 => 181761)


--- trunk/Websites/perf.webkit.org/ChangeLog	2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2015-03-19 22:36:43 UTC (rev 181761)
@@ -1,3 +1,15 @@
+2015-03-19  Ryosuke Niwa  <[email protected]>
+
+        Unreviewed build fixes.
+
+        * public/include/manifest.php:
+        (Manifest::generate): These should be {} instead of [] when they're empty.
+        * public/v2/data.js:
+        (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
+        * public/v2/manifest.js:
+        (App.Metric.fullName): Fixed the typo.
+        * tests/admin-regenerate-manifest.js: Fixed the test.
+
 2015-02-20  Ryosuke Niwa  <[email protected]>
 
         Commit the erroneously reverted change.

Modified: trunk/Websites/perf.webkit.org/public/include/manifest.php (181760 => 181761)


--- trunk/Websites/perf.webkit.org/public/include/manifest.php	2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/public/include/manifest.php	2015-03-19 22:36:43 UTC (rev 181761)
@@ -27,14 +27,14 @@
             $row = $row['commit_repository'];
 
         $this->manifest = array(
-            'tests' => $this->tests(),
-            'metrics' => $this->metrics(),
-            'all' => $this->platforms($config_table, $platform_table, false),
-            'dashboard' => $this->platforms($config_table, $platform_table, true),
-            'repositories' => $this->repositories($repositories_table, $repositories_with_commit),
-            'builders' => $this->builders(),
-            'bugTrackers' => $this->bug_trackers($repositories_table),
-            'dashboards' => config('dashboards'),
+            'tests' => (object)$this->tests(),
+            'metrics' => (object)$this->metrics(),
+            'all' => (object)$this->platforms($config_table, $platform_table, false),
+            'dashboard' => (object)$this->platforms($config_table, $platform_table, true),
+            'repositories' => (object)$this->repositories($repositories_table, $repositories_with_commit),
+            'builders' => (object)$this->builders(),
+            'bugTrackers' => (object)$this->bug_trackers($repositories_table),
+            'dashboards' => (object)config('dashboards'),
         );
 
         $this->manifest['elapsedTime'] = (microtime(true) - $start_time) * 1000;

Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (181760 => 181761)


--- trunk/Websites/perf.webkit.org/public/v2/data.js	2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js	2015-03-19 22:36:43 UTC (rev 181761)
@@ -173,7 +173,7 @@
     var formattedRevisions = {};
     for (var repositoryId in revisions) {
         var currentRevision = revisions[repositoryId][0];
-        var previousRevision = previousRevisions ? previousRevisions[repositoryId][0] : null;
+        var previousRevision = previousRevisions && previousRevisions[repositoryId] ? previousRevisions[repositoryId][0] : null;
         var formatttedRevision = Measurement.formatRevisionRange(currentRevision, previousRevision);
         formattedRevisions[repositoryId] = formatttedRevision;
     }

Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (181760 => 181761)


--- trunk/Websites/perf.webkit.org/public/v2/manifest.js	2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js	2015-03-19 22:36:43 UTC (rev 181761)
@@ -34,7 +34,7 @@
     }.property('name', 'test'),
     fullName: function ()
     {
-        return this.get('path').join(' \u220b ') /* &in; */
+        return this.get('path').join(' \u220b ') /* &ni; */
             + ' : ' + this.get('label');
     }.property('path', 'label'),
 });

Modified: trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js (181760 => 181761)


--- trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js	2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js	2015-03-19 22:36:43 UTC (rev 181761)
@@ -8,14 +8,15 @@
                 var manifest = JSON.parse(response.responseText);
                 delete manifest.defaultDashboard;
                 delete manifest.dashboards;
+                delete manifest.elapsedTime;
                 assert.deepEqual(manifest, {
-                    all: [],
-                    bugTrackers: [],
-                    builders: [],
-                    dashboard: [],
-                    metrics: [],
-                    repositories: [],
-                    tests: []});
+                    all: {},
+                    bugTrackers: {},
+                    builders: {},
+                    dashboard: {},
+                    metrics: {},
+                    repositories: {},
+                    tests: {}});
                 notifyDone();
             });
         });

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to