- Revision
- 181833
- Author
- [email protected]
- Date
- 2015-03-22 11:25:16 -0700 (Sun, 22 Mar 2015)
Log Message
tests/stress/*tdz* tests do 10x more iterations than necessary
https://bugs.webkit.org/show_bug.cgi?id=142946
Reviewed by Ryosuke Niwa.
The stress test harness runs all of these tests in various configurations. This includes
no-cjit, which has tier-up heuristics locked in such a way that 10,000 iterations is
enough to get to the highest tier. The only exceptions are very large functions or
functions that have some reoptimizations. That happens rarely, and when it does happen,
usually 20,000 iterations is enough.
Therefore, these tests use 10x too many iterations. This is bad, since these tests
allocate on each iteration, and so they run very slowly in debug mode.
* tests/stress/class-syntax-no-loop-tdz.js:
* tests/stress/class-syntax-no-tdz-in-catch.js:
* tests/stress/class-syntax-no-tdz-in-conditional.js:
* tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js:
* tests/stress/class-syntax-no-tdz-in-loop.js:
* tests/stress/class-syntax-no-tdz.js:
* tests/stress/class-syntax-tdz-in-catch.js:
* tests/stress/class-syntax-tdz-in-conditional.js:
* tests/stress/class-syntax-tdz-in-loop.js:
* tests/stress/class-syntax-tdz.js:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (181832 => 181833)
--- trunk/Source/_javascript_Core/ChangeLog 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-03-22 18:25:16 UTC (rev 181833)
@@ -1,3 +1,30 @@
+2015-03-22 Filip Pizlo <[email protected]>
+
+ tests/stress/*tdz* tests do 10x more iterations than necessary
+ https://bugs.webkit.org/show_bug.cgi?id=142946
+
+ Reviewed by Ryosuke Niwa.
+
+ The stress test harness runs all of these tests in various configurations. This includes
+ no-cjit, which has tier-up heuristics locked in such a way that 10,000 iterations is
+ enough to get to the highest tier. The only exceptions are very large functions or
+ functions that have some reoptimizations. That happens rarely, and when it does happen,
+ usually 20,000 iterations is enough.
+
+ Therefore, these tests use 10x too many iterations. This is bad, since these tests
+ allocate on each iteration, and so they run very slowly in debug mode.
+
+ * tests/stress/class-syntax-no-loop-tdz.js:
+ * tests/stress/class-syntax-no-tdz-in-catch.js:
+ * tests/stress/class-syntax-no-tdz-in-conditional.js:
+ * tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js:
+ * tests/stress/class-syntax-no-tdz-in-loop.js:
+ * tests/stress/class-syntax-no-tdz.js:
+ * tests/stress/class-syntax-tdz-in-catch.js:
+ * tests/stress/class-syntax-tdz-in-conditional.js:
+ * tests/stress/class-syntax-tdz-in-loop.js:
+ * tests/stress/class-syntax-tdz.js:
+
2015-03-21 Joseph Pecoraro <[email protected]>
Fix a typo in Parser error message
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-no-loop-tdz.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-no-loop-tdz.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-no-loop-tdz.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -16,5 +16,5 @@
noInline(B);
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
new B();
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-catch.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-catch.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-catch.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -15,5 +15,5 @@
noInline(B);
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
new B();
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-conditional.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-conditional.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-conditional.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -14,5 +14,5 @@
noInline(B);
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
new B(false);
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -21,5 +21,5 @@
noInline(B);
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
new B();
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-loop.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-loop.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz-in-loop.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -19,5 +19,5 @@
noInline(B);
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
new B();
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-no-tdz.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -12,5 +12,5 @@
noInline(B);
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
new B();
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-catch.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-catch.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-catch.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -16,7 +16,7 @@
noInline(B);
-for (var i = 0; i < 100000; ++i) {
+for (var i = 0; i < 10000; ++i) {
var exception = null;
try {
new B(false);
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-conditional.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-conditional.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-conditional.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -16,7 +16,7 @@
noInline(B);
-for (var i = 0; i < 100000; ++i) {
+for (var i = 0; i < 10000; ++i) {
var exception = null;
try {
new B(false);
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-loop.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-loop.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz-in-loop.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -16,7 +16,7 @@
noInline(B);
-for (var i = 0; i < 100000; ++i) {
+for (var i = 0; i < 10000; ++i) {
var exception = null;
try {
new B();
Modified: trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz.js (181832 => 181833)
--- trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz.js 2015-03-22 04:55:33 UTC (rev 181832)
+++ trunk/Source/_javascript_Core/tests/stress/class-syntax-tdz.js 2015-03-22 18:25:16 UTC (rev 181833)
@@ -12,7 +12,7 @@
noInline(B);
-for (var i = 0; i < 100000; ++i) {
+for (var i = 0; i < 10000; ++i) {
var exception;
try {
new B();
