Title: [181860] trunk/Source/WebCore
- Revision
- 181860
- Author
- [email protected]
- Date
- 2015-03-23 12:20:24 -0700 (Mon, 23 Mar 2015)
Log Message
[iOS] Accessibility crashing because MediaPlayer is laying out UI off the main thread
https://bugs.webkit.org/show_bug.cgi?id=142970
Reviewed by Eric Carlson.
Return early after synchronously calling to the main thread to allocate the volume
view, to avoid re-allocating the volume view again on the web thread.
* platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper allocateVolumeView]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (181859 => 181860)
--- trunk/Source/WebCore/ChangeLog 2015-03-23 19:13:29 UTC (rev 181859)
+++ trunk/Source/WebCore/ChangeLog 2015-03-23 19:20:24 UTC (rev 181860)
@@ -1,3 +1,16 @@
+2015-03-23 Jer Noble <[email protected]>
+
+ [iOS] Accessibility crashing because MediaPlayer is laying out UI off the main thread
+ https://bugs.webkit.org/show_bug.cgi?id=142970
+
+ Reviewed by Eric Carlson.
+
+ Return early after synchronously calling to the main thread to allocate the volume
+ view, to avoid re-allocating the volume view again on the web thread.
+
+ * platform/audio/ios/MediaSessionManagerIOS.mm:
+ (-[WebMediaSessionHelper allocateVolumeView]):
+
2015-03-23 Tim Horton <[email protected]>
Add a share item to the link action menu
Modified: trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm (181859 => 181860)
--- trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm 2015-03-23 19:13:29 UTC (rev 181859)
+++ trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm 2015-03-23 19:20:24 UTC (rev 181860)
@@ -251,8 +251,8 @@
RetainPtr<WebMediaSessionHelper> strongSelf = self;
dispatch_sync(dispatch_get_main_queue(), [strongSelf]() {
[strongSelf allocateVolumeView];
- return;
});
+ return;
}
_volumeView = adoptNS([allocMPVolumeViewInstance() init]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
