Title: [181919] trunk/Source/WebKit2
- Revision
- 181919
- Author
- [email protected]
- Date
- 2015-03-24 16:37:34 -0700 (Tue, 24 Mar 2015)
Log Message
[iOS] Remove unused keyboard code in WKSelectPopover class.
https://bugs.webkit.org/show_bug.cgi?id=143021
Reviewed by Joseph Pecoraro.
WKSelectPopover created an instance of UIKeyboard that was
initialized in initWithView but never used. Removing the
obsolete code.
* UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover initWithView:hasGroups:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (181918 => 181919)
--- trunk/Source/WebKit2/ChangeLog 2015-03-24 23:25:47 UTC (rev 181918)
+++ trunk/Source/WebKit2/ChangeLog 2015-03-24 23:37:34 UTC (rev 181919)
@@ -1,3 +1,17 @@
+2015-03-24 Enrica Casucci <[email protected]>
+
+ [iOS] Remove unused keyboard code in WKSelectPopover class.
+ https://bugs.webkit.org/show_bug.cgi?id=143021
+
+ Reviewed by Joseph Pecoraro.
+
+ WKSelectPopover created an instance of UIKeyboard that was
+ initialized in initWithView but never used. Removing the
+ obsolete code.
+
+ * UIProcess/ios/forms/WKFormSelectPopover.mm:
+ (-[WKSelectPopover initWithView:hasGroups:]):
+
2015-03-24 Dan Bernstein <[email protected]>
WebKit2 part of <rdar://problem/20282863> Transforms are flattened in snapshots of on-screen WKWebViews
Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm (181918 => 181919)
--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm 2015-03-24 23:25:47 UTC (rev 181918)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm 2015-03-24 23:37:34 UTC (rev 181919)
@@ -369,7 +369,6 @@
@implementation WKSelectPopover {
WKContentView *_view;
RetainPtr<WKSelectTableViewController> _tableViewController;
- RetainPtr<UIKeyboard> _keyboard;
}
- (instancetype)initWithView:(WKContentView *)view hasGroups:(BOOL)hasGroups
@@ -381,7 +380,6 @@
CGRect frame;
frame.origin = CGPointZero;
frame.size = [UIKeyboard defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]];
- _keyboard = adoptNS([[UIKeyboard alloc] initWithFrame:frame]);
_tableViewController = adoptNS([[WKSelectTableViewController alloc] initWithView:view hasGroups:hasGroups]);
[_tableViewController setPopover:self];
@@ -407,10 +405,6 @@
[navController release];
[[UIKeyboardImpl sharedInstance] setDelegate:_tableViewController.get()];
- [_keyboard setSize:[UIKeyboard defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]]];
- [_keyboard prepareForGeometryChange];
- [_keyboard geometryChangeDone:NO];
- [_keyboard activate];
return self;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
