Title: [182043] trunk/Source/_javascript_Core
- Revision
- 182043
- Author
- [email protected]
- Date
- 2015-03-26 16:41:16 -0700 (Thu, 26 Mar 2015)
Log Message
Function.prototype.toString should not decompile the AST
https://bugs.webkit.org/show_bug.cgi?id=142853
Reviewed by Darin Adler.
Following up on Darin's review comments.
* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (182042 => 182043)
--- trunk/Source/_javascript_Core/ChangeLog 2015-03-26 23:38:12 UTC (rev 182042)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-03-26 23:41:16 UTC (rev 182043)
@@ -1,5 +1,17 @@
2015-03-26 Geoffrey Garen <[email protected]>
+ Function.prototype.toString should not decompile the AST
+ https://bugs.webkit.org/show_bug.cgi?id=142853
+
+ Reviewed by Darin Adler.
+
+ Following up on Darin's review comments.
+
+ * runtime/FunctionConstructor.cpp:
+ (JSC::constructFunctionSkippingEvalEnabledCheck):
+
+2015-03-26 Geoffrey Garen <[email protected]>
+
"lineNo" does not match WebKit coding style guidelines
https://bugs.webkit.org/show_bug.cgi?id=143119
Modified: trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp (182042 => 182043)
--- trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp 2015-03-26 23:38:12 UTC (rev 182042)
+++ trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp 2015-03-26 23:41:16 UTC (rev 182043)
@@ -102,10 +102,10 @@
StringBuilder builder;
builder.appendLiteral("{function ");
builder.append(functionName.string());
- builder.append("(");
+ builder.append('(');
builder.append(args.at(0).toString(exec)->value(exec));
for (size_t i = 1; i < args.size() - 1; i++) {
- builder.append(", ");
+ builder.appendLiteral(", ");
builder.append(args.at(i).toString(exec)->value(exec));
}
builder.appendLiteral(") {\n");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
