Title: [182052] trunk/Source/WebCore
- Revision
- 182052
- Author
- [email protected]
- Date
- 2015-03-26 23:36:48 -0700 (Thu, 26 Mar 2015)
Log Message
Optimized Fullscreen fails to cleanup because of no longer necessary release of m_playerController in exitFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=143120
Patch by Jeremy Jones <[email protected]> on 2015-03-26
Reviewed by Eric Carlson.
We used to release m_playerController in WebVideoFullscreenInterfaceAVKit::exitFullscreen() in order to make sure
media state was reset. This is no longer necessary as we now have a way the model can explicitly request resetting the
media state via resetMediaState(). m_playerController is already released in
WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releasing it prematurely can actually prevent the exit
fullscreen process from completing successfully.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (182051 => 182052)
--- trunk/Source/WebCore/ChangeLog 2015-03-27 04:41:46 UTC (rev 182051)
+++ trunk/Source/WebCore/ChangeLog 2015-03-27 06:36:48 UTC (rev 182052)
@@ -1,3 +1,19 @@
+2015-03-26 Jeremy Jones <[email protected]>
+
+ Optimized Fullscreen fails to cleanup because of no longer necessary release of m_playerController in exitFullscreen()
+ https://bugs.webkit.org/show_bug.cgi?id=143120
+
+ Reviewed by Eric Carlson.
+
+ We used to release m_playerController in WebVideoFullscreenInterfaceAVKit::exitFullscreen() in order to make sure
+ media state was reset. This is no longer necessary as we now have a way the model can explicitly request resetting the
+ media state via resetMediaState(). m_playerController is already released in
+ WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releasing it prematurely can actually prevent the exit
+ fullscreen process from completing successfully.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (WebVideoFullscreenInterfaceAVKit::exitFullscreen):
+
2015-03-26 Zalan Bujtas <[email protected]>
Inline continuation code should not take anonymous containing wrapper granted.
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (182051 => 182052)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-03-27 04:41:46 UTC (rev 182051)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-03-27 06:36:48 UTC (rev 182052)
@@ -1024,8 +1024,6 @@
return;
}
- m_playerController = nil;
-
dispatch_async(dispatch_get_main_queue(), [strongThis, finalRect] {
strongThis->exitFullscreenInternal(finalRect);
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
