Title: [182066] tags/Safari-601.1.23.4/Source/WebCore
- Revision
- 182066
- Author
- [email protected]
- Date
- 2015-03-27 10:00:08 -0700 (Fri, 27 Mar 2015)
Log Message
Merged r182052. rdar://problem/20263463
Modified Paths
Diff
Modified: tags/Safari-601.1.23.4/Source/WebCore/ChangeLog (182065 => 182066)
--- tags/Safari-601.1.23.4/Source/WebCore/ChangeLog 2015-03-27 16:59:24 UTC (rev 182065)
+++ tags/Safari-601.1.23.4/Source/WebCore/ChangeLog 2015-03-27 17:00:08 UTC (rev 182066)
@@ -1,3 +1,23 @@
+2015-03-27 Babak Shafiei <[email protected]>
+
+ Merge r182052.
+
+ 2015-03-26 Jeremy Jones <[email protected]>
+
+ Optimized Fullscreen fails to cleanup because of no longer necessary release of m_playerController in exitFullscreen()
+ https://bugs.webkit.org/show_bug.cgi?id=143120
+
+ Reviewed by Eric Carlson.
+
+ We used to release m_playerController in WebVideoFullscreenInterfaceAVKit::exitFullscreen() in order to make sure
+ media state was reset. This is no longer necessary as we now have a way the model can explicitly request resetting the
+ media state via resetMediaState(). m_playerController is already released in
+ WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releasing it prematurely can actually prevent the exit
+ fullscreen process from completing successfully.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (WebVideoFullscreenInterfaceAVKit::exitFullscreen):
+
2015-03-19 Matthew Hanson <[email protected]>
Merge r181662. rdar://problem/20144648
Modified: tags/Safari-601.1.23.4/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (182065 => 182066)
--- tags/Safari-601.1.23.4/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-03-27 16:59:24 UTC (rev 182065)
+++ tags/Safari-601.1.23.4/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-03-27 17:00:08 UTC (rev 182066)
@@ -1024,8 +1024,6 @@
return;
}
- m_playerController = nil;
-
dispatch_async(dispatch_get_main_queue(), [strongThis, finalRect] {
strongThis->exitFullscreenInternal(finalRect);
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
