Title: [182074] trunk/Source/WebKit2
- Revision
- 182074
- Author
- [email protected]
- Date
- 2015-03-27 13:17:00 -0700 (Fri, 27 Mar 2015)
Log Message
[WK2][NetworkCache] Rename requestNeedsRevalidation() to requestRequiresRevalidation()
https://bugs.webkit.org/show_bug.cgi?id=143137
Reviewed by Antti Koivisto.
Rename requestNeedsRevalidation() to requestRequiresRevalidation() as I
think it is more accurate. It is not the request that needs revalidating.
The requests just requires us to revalidate the response.
* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::requestRequiresRevalidation):
(WebKit::NetworkCache::canUse):
(WebKit::NetworkCache::requestNeedsRevalidation): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (182073 => 182074)
--- trunk/Source/WebKit2/ChangeLog 2015-03-27 19:04:28 UTC (rev 182073)
+++ trunk/Source/WebKit2/ChangeLog 2015-03-27 20:17:00 UTC (rev 182074)
@@ -1,3 +1,19 @@
+2015-03-27 Chris Dumez <[email protected]>
+
+ [WK2][NetworkCache] Rename requestNeedsRevalidation() to requestRequiresRevalidation()
+ https://bugs.webkit.org/show_bug.cgi?id=143137
+
+ Reviewed by Antti Koivisto.
+
+ Rename requestNeedsRevalidation() to requestRequiresRevalidation() as I
+ think it is more accurate. It is not the request that needs revalidating.
+ The requests just requires us to revalidate the response.
+
+ * NetworkProcess/cache/NetworkCache.cpp:
+ (WebKit::NetworkCache::requestRequiresRevalidation):
+ (WebKit::NetworkCache::canUse):
+ (WebKit::NetworkCache::requestNeedsRevalidation): Deleted.
+
2015-03-27 Oliver Hunt <[email protected]>
Forward additional CFNetwork ATS information to child processes
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp (182073 => 182074)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp 2015-03-27 19:04:28 UTC (rev 182073)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp 2015-03-27 20:17:00 UTC (rev 182074)
@@ -169,7 +169,7 @@
return hasExpired;
}
-static bool requestNeedsRevalidation(const WebCore::ResourceRequest& request)
+static bool requestRequiresRevalidation(const WebCore::ResourceRequest& request)
{
auto requestDirectives = WebCore::parseCacheControlDirectives(request.httpHeaderFields());
if (requestDirectives.noCache)
@@ -192,7 +192,7 @@
if (cachePolicyAllowsExpired(request.cachePolicy()))
return UseDecision::Use;
- bool needsRevalidation = requestNeedsRevalidation(request) || responseHasExpired(entry.response(), entry.timeStamp());
+ bool needsRevalidation = requestRequiresRevalidation(request) || responseHasExpired(entry.response(), entry.timeStamp());
if (!needsRevalidation)
return UseDecision::Use;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
