Title: [182077] trunk/Source/WebCore
- Revision
- 182077
- Author
- [email protected]
- Date
- 2015-03-27 14:02:31 -0700 (Fri, 27 Mar 2015)
Log Message
Calling crypto.webkitSubtle.generateKey causes page memory to never be released
https://bugs.webkit.org/show_bug.cgi?id=143151
rdar://problem/18940687
Reviewed by Tim Horton.
* crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::generatePair): Don't.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (182076 => 182077)
--- trunk/Source/WebCore/ChangeLog 2015-03-27 20:41:33 UTC (rev 182076)
+++ trunk/Source/WebCore/ChangeLog 2015-03-27 21:02:31 UTC (rev 182077)
@@ -1,3 +1,13 @@
+2015-03-27 Alexey Proskuryakov <[email protected]>
+
+ Calling crypto.webkitSubtle.generateKey causes page memory to never be released
+ https://bugs.webkit.org/show_bug.cgi?id=143151
+ rdar://problem/18940687
+
+ Reviewed by Tim Horton.
+
+ * crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::generatePair): Don't.
+
2015-03-27 Brent Fulgham <[email protected]>
Null dereference in InbandMetadataTextTrack handling
Modified: trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp (182076 => 182077)
--- trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2015-03-27 20:41:33 UTC (rev 182076)
+++ trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2015-03-27 21:02:31 UTC (rev 182077)
@@ -261,6 +261,7 @@
WTFLogAlways("Could not generate a key pair, status %d", status);
callOnWebThreadOrDispatchAsyncOnMainThread(^{
(*localFailureCallback)();
+ delete localCallback;
delete localFailureCallback;
});
return;
@@ -270,6 +271,7 @@
RefPtr<CryptoKeyRSA> privateKey = CryptoKeyRSA::create(algorithm, CryptoKeyType::Private, ccPrivateKey, extractable, usage);
(*localCallback)(CryptoKeyPair::create(publicKey.release(), privateKey.release()));
delete localCallback;
+ delete localFailureCallback;
});
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
