Title: [182092] trunk/Source/WebInspectorUI
- Revision
- 182092
- Author
- [email protected]
- Date
- 2015-03-27 17:51:18 -0700 (Fri, 27 Mar 2015)
Log Message
Web Inspector: Uncaught Exception: TypeError: Attempted to assign to readonly - DOMNodeDetailsSidebarPanel.js
https://bugs.webkit.org/show_bug.cgi?id=143139
Patch by Joseph Pecoraro <[email protected]> on 2015-03-27
Reviewed by Timothy Hatcher.
DataGridNodes do not have a selectable setter. TreeElements do.
DataGridNodes are always selectable. Match current behavior by
removing all instances of attempting to set the selectability
which would, under strict mode, result in an error.
* UserInterface/Views/ApplicationCacheFrameContentView.js:
(WebInspector.ApplicationCacheFrameContentView.prototype._populateDataGrid):
* UserInterface/Views/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView.prototype._rebuildTable):
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._createAttributesDataGrid):
(WebInspector.DOMNodeDetailsSidebarPanel):
* UserInterface/Views/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView.prototype.reset):
* UserInterface/Views/DataGrid.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (182091 => 182092)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-03-28 00:40:56 UTC (rev 182091)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-03-28 00:51:18 UTC (rev 182092)
@@ -1,3 +1,26 @@
+2015-03-27 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Uncaught Exception: TypeError: Attempted to assign to readonly - DOMNodeDetailsSidebarPanel.js
+ https://bugs.webkit.org/show_bug.cgi?id=143139
+
+ Reviewed by Timothy Hatcher.
+
+ DataGridNodes do not have a selectable setter. TreeElements do.
+ DataGridNodes are always selectable. Match current behavior by
+ removing all instances of attempting to set the selectability
+ which would, under strict mode, result in an error.
+
+ * UserInterface/Views/ApplicationCacheFrameContentView.js:
+ (WebInspector.ApplicationCacheFrameContentView.prototype._populateDataGrid):
+ * UserInterface/Views/CookieStorageContentView.js:
+ (WebInspector.CookieStorageContentView.prototype._rebuildTable):
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+ (WebInspector.DOMNodeDetailsSidebarPanel.prototype._createAttributesDataGrid):
+ (WebInspector.DOMNodeDetailsSidebarPanel):
+ * UserInterface/Views/DOMStorageContentView.js:
+ (WebInspector.DOMStorageContentView.prototype.reset):
+ * UserInterface/Views/DataGrid.js:
+
2015-03-26 Timothy Hatcher <[email protected]>
Web Inspector: Convert more misc View classes to ES6
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js (182091 => 182092)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js 2015-03-28 00:40:56 UTC (rev 182091)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js 2015-03-28 00:51:18 UTC (rev 182092)
@@ -219,7 +219,6 @@
size: Number.bytesToString(resource.size)
};
var node = new WebInspector.DataGridNode(data);
- node.selectable = true;
this._dataGrid.appendChild(node);
}
},
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js (182091 => 182092)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2015-03-28 00:40:56 UTC (rev 182091)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2015-03-28 00:51:18 UTC (rev 182092)
@@ -148,7 +148,6 @@
data["expires"] = cookie.session ? WebInspector.UIString("Session") : new Date(cookie.expires).toLocaleString();
var node = new WebInspector.DataGridNode(data);
- node.selectable = true;
node.cookie = cookie;
this._dataGrid.appendChild(node);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (182091 => 182092)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2015-03-28 00:40:56 UTC (rev 182091)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2015-03-28 00:51:18 UTC (rev 182092)
@@ -584,8 +584,6 @@
var attribute = attributes[i];
var node = new WebInspector.DataGridNode({name: attribute.name, value: attribute.value || ""}, false);
- node.selectable = true;
-
dataGrid.appendChild(node);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js (182091 => 182092)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js 2015-03-28 00:40:56 UTC (rev 182091)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js 2015-03-28 00:51:18 UTC (rev 182092)
@@ -80,7 +80,6 @@
continue;
var data = "" entry[0], value: entry[1]};
var node = new WebInspector.DataGridNode(data, false);
- node.selectable = true;
this._dataGrid.appendChild(node);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (182091 => 182092)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2015-03-28 00:40:56 UTC (rev 182091)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2015-03-28 00:51:18 UTC (rev 182092)
@@ -141,7 +141,6 @@
data[columnNames[j]] = values[numColumns * i + j];
var node = new WebInspector.DataGridNode(data, false);
- node.selectable = false;
dataGrid.appendChild(node);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
