Title: [182102] trunk/Source/_javascript_Core
- Revision
- 182102
- Author
- [email protected]
- Date
- 2015-03-27 21:02:49 -0700 (Fri, 27 Mar 2015)
Log Message
parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind
https://bugs.webkit.org/show_bug.cgi?id=143170
Reviewed by Benjamin Poulain.
Assert that we never use 16-bit version of the parser to parse a default constructor
since both base and derived default constructors should be using a 8-bit string.
* parser/Parser.h:
(JSC::parse):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (182101 => 182102)
--- trunk/Source/_javascript_Core/ChangeLog 2015-03-28 03:15:07 UTC (rev 182101)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-03-28 04:02:49 UTC (rev 182102)
@@ -1,5 +1,18 @@
2015-03-27 Ryosuke Niwa <[email protected]>
+ parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind
+ https://bugs.webkit.org/show_bug.cgi?id=143170
+
+ Reviewed by Benjamin Poulain.
+
+ Assert that we never use 16-bit version of the parser to parse a default constructor
+ since both base and derived default constructors should be using a 8-bit string.
+
+ * parser/Parser.h:
+ (JSC::parse):
+
+2015-03-27 Ryosuke Niwa <[email protected]>
+
ES6 Classes: Runtime error in JIT'd class calling super() with arguments and superclass has default constructor
https://bugs.webkit.org/show_bug.cgi?id=142862
Modified: trunk/Source/_javascript_Core/parser/Parser.h (182101 => 182102)
--- trunk/Source/_javascript_Core/parser/Parser.h 2015-03-28 03:15:07 UTC (rev 182101)
+++ trunk/Source/_javascript_Core/parser/Parser.h 2015-03-28 04:02:49 UTC (rev 182102)
@@ -1006,6 +1006,7 @@
}
return result;
}
+ ASSERT_WITH_MESSAGE(defaultConstructorKind == ConstructorKind::None, "BuiltinExecutables::createDefaultConstructor should always use a 8-bit string");
Parser<Lexer<UChar>> parser(vm, source, parameters, name, builtinMode, strictMode, codeType);
std::unique_ptr<ParsedNode> result = parser.parse<ParsedNode>(error);
if (positionBeforeLastNewline)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
